Add BaseModel Concepts and Error messages#159
Merged
Conversation
koparasy
changed the title
lpottier
approved these changes
Nov 25, 2025
Member
There was a problem hiding this comment.
It looks good to me. Thanks for the hard work, getting rid of the shim layer in C is a good thing.
It's a very large PR in terms of coverage. We might want to break it down into smaller pieces and keep the rest of your TODO list for future PRs (the doc etc).
koparasy
commented
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is one of the many PRs we will do over the next months to deprecate the C-shim layer. The PR provides some core infrastructure:
tl::expectedfor AMSError codesfmtto create error message