Conversation
There was a problem hiding this comment.
Pull request overview
This pull request introduces a new TensorBundle class, a lightweight container for grouping named tensors to represent inputs, in-out parameters, and outputs in AMS evaluation pipelines.
- Adds a header-only
TensorBundlestruct with Item management, copy/move semantics, and iteration support - Provides comprehensive unit tests covering construction, item access, iteration, copy/move semantics, and clearing
- Integrates the new test into the CMake build system
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/AMSlib/wf/tensor_bundle.hpp | Defines the TensorBundle struct with methods for managing named tensors including add, access, iteration, and clearing operations |
| tests/AMSlib/wf/test_tensor_bundle.cpp | Provides comprehensive unit tests covering all major functionality of TensorBundle |
| tests/AMSlib/wf/CMakeLists.txt | Adds build and test registration for the new tensor bundle unit test |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
9 tasks
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
9 tasks
There was a problem hiding this comment.
Cpp-linter Review
Used clang-format v18.1.8
Click here for the full clang-format patch
diff --git a/src/AMSlib/wf/tensor_bundle.hpp b/src/AMSlib/wf/tensor_bundle.hpp
index eee2ec4..3d4312f 100644
--- a/src/AMSlib/wf/tensor_bundle.hpp
+++ b/src/AMSlib/wf/tensor_bundle.hpp
@@ -68 +68,2 @@ struct TensorBundle {
- Item* find(const std::string& name) noexcept {
+ Item* find(const std::string& name) noexcept
+ {
@@ -78 +79,2 @@ struct TensorBundle {
- const Item* find(const std::string& name) const noexcept {
+ const Item* find(const std::string& name) const noexcept
+ {
Have any feedback or feature suggestions? Share it here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.