Skip to content

Introduce tensor bundle#170

Merged
koparasy merged 10 commits intodevelopfrom
features/tensor_bundle
Dec 5, 2025
Merged

Introduce tensor bundle#170
koparasy merged 10 commits intodevelopfrom
features/tensor_bundle

Conversation

@koparasy
Copy link
Member

@koparasy koparasy commented Dec 4, 2025

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request introduces a new TensorBundle class, a lightweight container for grouping named tensors to represent inputs, in-out parameters, and outputs in AMS evaluation pipelines.

  • Adds a header-only TensorBundle struct with Item management, copy/move semantics, and iteration support
  • Provides comprehensive unit tests covering construction, item access, iteration, copy/move semantics, and clearing
  • Integrates the new test into the CMake build system

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File Description
src/AMSlib/wf/tensor_bundle.hpp Defines the TensorBundle struct with methods for managing named tensors including add, access, iteration, and clearing operations
tests/AMSlib/wf/test_tensor_bundle.cpp Provides comprehensive unit tests covering all major functionality of TensorBundle
tests/AMSlib/wf/CMakeLists.txt Adds build and test registration for the new tensor bundle unit test

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI commented Dec 4, 2025

@koparasy I've opened a new pull request, #171, to work on those changes. Once the pull request is ready, I'll request review from you.

koparasy and others added 3 commits December 4, 2025 09:14
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link

Copilot AI commented Dec 4, 2025

@koparasy I've opened a new pull request, #172, to work on those changes. Once the pull request is ready, I'll request review from you.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cpp-linter Review

Used clang-format v18.1.8

Click here for the full clang-format patch
diff --git a/src/AMSlib/wf/tensor_bundle.hpp b/src/AMSlib/wf/tensor_bundle.hpp
index eee2ec4..3d4312f 100644
--- a/src/AMSlib/wf/tensor_bundle.hpp
+++ b/src/AMSlib/wf/tensor_bundle.hpp
@@ -68 +68,2 @@ struct TensorBundle {
-  Item* find(const std::string& name) noexcept {
+  Item* find(const std::string& name) noexcept
+  {
@@ -78 +79,2 @@ struct TensorBundle {
-  const Item* find(const std::string& name) const noexcept {
+  const Item* find(const std::string& name) const noexcept
+  {

Have any feedback or feature suggestions? Share it here.

@koparasy koparasy merged commit 070f8a7 into develop Dec 5, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants