Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive unit test coverage for the EvalContext class, which appears to be a new component in the AMS workflow system that manages evaluation contexts including input/output tensors, model pointers, thresholds, and uncertainty tracking.
Key Changes:
- Added unit tests covering default construction, parameterized construction, and optional uncertainties usage for
EvalContext - Updated CMake configuration to build and register the new test executable
- Tests verify correct initialization and management of tensor bundles, model/layout pointers, thresholds, and optional fields
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/AMSlib/wf/eval_context.cpp | New test file with three test cases validating EvalContext construction and field initialization |
| tests/AMSlib/wf/CMakeLists.txt | Added build and registration configuration for the eval_context test executable |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.