Open
Conversation
MrBurmark
reviewed
Dec 4, 2024
long58
commented
Dec 4, 2024
…into feature/long58/sycl_scan_sort
…into feature/long58/sycl_scan_sort
rhornung67
reviewed
Dec 19, 2024
rhornung67
reviewed
Dec 19, 2024
rhornung67
reviewed
Dec 19, 2024
MrBurmark
reviewed
Dec 20, 2024
MrBurmark
reviewed
Dec 20, 2024
Comment on lines
+76
to
+77
| auto buffAccessor = buffPtr->get_access(cgh); | ||
| auto tempAccessor = tempPtr->get_access(cgh); |
Member
There was a problem hiding this comment.
I'm not familiar with how sycl::buffer objects work, do they make a copy of the data?
Contributor
Author
There was a problem hiding this comment.
If the data is already on the device, then no, otherwise yes, it will copy from the host to the device and synchronize them automatically when changes are made to one or the other.
MrBurmark
reviewed
Dec 20, 2024
MrBurmark
reviewed
Dec 20, 2024
long58
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fulfills #1669. This PR implements a parallel scan algorithm in Sycl.