cmake: Add argument to RAJA add code checks macro#1972
Open
johnbowen42 wants to merge 3 commits intodevelopfrom
Open
cmake: Add argument to RAJA add code checks macro#1972johnbowen42 wants to merge 3 commits intodevelopfrom
johnbowen42 wants to merge 3 commits intodevelopfrom
Conversation
Member
|
@johnbowen42 thanks for adding this. After the benchmarking stuff is rolled out, we will need to discuss how to apply formatting to RAJA Perf, many opportunities to make complicated code unreadable 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simple PR add arguments to the raja_add_code_checks macro rather than manually setting directories within the function definition. As discussed offline between @artv3 and myself, this allows RAJAPerf to include the macro and reuse it to format RAJAPerf files.