Add thread filtering support for gdb-oneapi callstack capture.#54
Add thread filtering support for gdb-oneapi callstack capture.#54abijaz wants to merge 1 commit intollnl:developfrom
Conversation
|
I can't test the PR, but it looks OK to me. Regarding documentation, can you send the output when you run the "doc/src/README" script and also the output of |
|
If it helps, here's the generated PDF file. My one request is for the documentation about STAT_INTELGT_EXPR_FILTER, please remove the single quotes for 'shell', 'call', etc. The markings should stand out enough and we don't single quote them in other parts of the documentation. Less importantly, in the "Security Note" perhaps shell, call, python should by highlighted like other commands. |
Thanks.
I will fix and update the PR. Kindly, please provide then the updated pdf again, I will then add it to PR also. |
abijaz
force-pushed
the
oneapi_gdb_upd
branch
from
c581857 to
477846b
Compare
I am using Ubuntu 22 and might be this is the reason then. I see lot of warnings |
Add two new environment variables to control thread selection during callstack capture: - STAT_GDB_MAX_THREADS: Limit capture to first N threads - STAT_INTELGT_EXPR_FILTER: Filter threads using GDB expression STAT_INTELGT_MAX_THREADS=100 will capture the first 100 threads. STAT_INTELGT_EXPR_FILTER allows selective thread capture using GDB expressions (e.g., "\$_thread <= 50" to capture only threads 1-50). Updated documentation to describe both environment variables with usage examples. The user guide pdf file is also regenerated accordingly. Signed-off-by: Abdul Basit Ijaz <abdul.b.ijaz@intel.com>
abijaz
force-pushed
the
oneapi_gdb_upd
branch
from
477846b to
afca1c6
Compare
|
@lee218llnl please review the latest changes to the pull request. The following updates have been made:
The PDF generation logs are provided below: |
|
It looks like the docbook commands worked OK, so perhaps those are just warnings. Can you look in ../userguide to see if the PDF is there? For me here's what I see: [lee218@dane5:src]$ pwd [lee218@dane5:src]$ ls ../userguide/ If that isn't there, then perhaps they are true errors. It looks like it doesn't like underscores, such as "stat_options". Can I trouble you to try removing the "_" character and use camel case, for instance change "stat_options" to "statOptions". Be sure to change all references. I could do this myself, but I have no way of testing whether it helps in your case, as my system doesn't generate those errors. |
It was not generated due to errors on Ubuntu 22 . But i was also able to generate it on RHEL8 without any additional changes.
Thanks for the pointer. Yes by replacing "_" character with camel case I was able to build it on Ubuntu22 also and then new user guide i verified was generated as expected. I can create a separate PR for it or shall I include all those changes in a separate commit in this same PR ? |
2 participants
Add two new environment variables to control thread selection during callstack capture:
STAT_INTELGT_MAX_THREADS=100 will capture the first 100 threads.
STAT_INTELGT_EXPR_FILTER allows selective thread capture using GDB expressions (e.g., "$_thread <= 50" to capture only threads 1-50).
Updated documentation to describe both environment variables with usage examples.
IMPORTANT NOTE: Could not generated the PDF file for the PR to include the change in documentation following https://github.com/llnl/STAT/blob/develop/doc/src/README. It fails to generate a PDF file.