Skip to content

remhos changes#1141

Open
rfhaque wants to merge 8 commits intodevelopfrom
remhos
Open

remhos changes#1141
rfhaque wants to merge 8 commits intodevelopfrom
remhos

Conversation

@rfhaque
Copy link
Collaborator

@rfhaque rfhaque commented Nov 16, 2025

Description

This PR:

  1. Adds a variant to experiment.py, application.py and package.py for enabling gpu-aware-mpi in remhos
  2. Enables umpire in hypre and mfem
  3. Enables GPU aware MPI in mfem

Adding/modifying a benchmark (docs: Adding a Benchmark)

  • If package.py upstreamed to Spack is insufficient, add/modify repo/benchmark_name/package.py plus: create, self-assign, and link here a follow up issue with a link to the PR in the Spack repo.
  • If application.py upstreamed to Ramble is insufficient, add/modify repo/benchmark_name/application.py plus: create, self-assign, and link here a follow up issue with a link to the PR in the Ramble repo.
  • Add/modify an experiments/benchmark_name/experiment.py to define an experiment

This PR depends on

@rfhaque rfhaque requested a review from pearce8 November 16, 2025 03:45
@github-actions github-actions bot added experiment New or modified experiment application labels Nov 16, 2025
@rfhaque rfhaque mentioned this pull request Nov 16, 2025
22 tasks
Copy link
Collaborator

@pearce8 pearce8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to think about GPU-aware MPI

description="app version",
)

variant(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nhanford Do we want a variant on this?

if self.spec.satisfies("+gpu-aware-mpi"):
gam = "+gpu-aware-mpi"
self.add_package_spec(
self.name, [f"remhos{self.determine_version()} +metis {gam}"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nhanford Do you think this is a reasonable way to pass on gpu aware requirements?

@pearce8 pearce8 added the WIP A work-in-progress not yet ready to commit label Feb 20, 2026
@pearce8 pearce8 added this to the February 2026 milestone Feb 24, 2026
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.59%. Comparing base (51e732e) to head (a2fbf76).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1141      +/-   ##
===========================================
+ Coverage    62.02%   63.59%   +1.56%     
===========================================
  Files           49       49              
  Lines         3758     3758              
  Branches       323      323              
===========================================
+ Hits          2331     2390      +59     
+ Misses        1416     1357      -59     
  Partials        11       11              

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

application experiment New or modified experiment WIP A work-in-progress not yet ready to commit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants