Conversation
added 2 commits
November 15, 2025 19:30
pearce8
requested changes
Dec 1, 2025
Collaborator
pearce8
left a comment
There was a problem hiding this comment.
Need to think about GPU-aware MPI
pearce8
reviewed
Dec 1, 2025
| description="app version", | ||
| ) | ||
|
|
||
| variant( |
pearce8
reviewed
Dec 1, 2025
| if self.spec.satisfies("+gpu-aware-mpi"): | ||
| gam = "+gpu-aware-mpi" | ||
| self.add_package_spec( | ||
| self.name, [f"remhos{self.determine_version()} +metis {gam}"] |
Collaborator
There was a problem hiding this comment.
@nhanford Do you think this is a reasonable way to pass on gpu aware requirements?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1141 +/- ##
===========================================
+ Coverage 62.02% 63.59% +1.56%
===========================================
Files 49 49
Lines 3758 3758
Branches 323 323
===========================================
+ Hits 2331 2390 +59
+ Misses 1416 1357 -59
Partials 11 11 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR:
experiment.py,application.pyandpackage.pyfor enabling gpu-aware-mpi in remhosAdding/modifying a benchmark (docs: Adding a Benchmark)
repo/benchmark_name/package.pyplus: create, self-assign, and link here a follow up issue with a link to the PR in the Spack repo.repo/benchmark_name/application.pyplus: create, self-assign, and link here a follow up issue with a link to the PR in the Ramble repo.experiments/benchmark_name/experiment.pyto define an experimentThis PR depends on