Draft
Conversation
1 task
Collaborator
Author
|
The downside of this Spack change is that I now have to specify |
Member
|
Interesting issue. So, if I understand correctly, the concretization issue comes from us enforcing a compiler dependency on a package that has none. But when removing the compiler, we lack a constraint to enforce coherency between the compiler / software stack version and the external package version... I feel like we should be able to set a requirement in the packages.yaml to keep that constraint without adding an imaginary dependency on the compiler. |
20ebf21 to
6bf05f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Encountered this issue when updating Quandary to newer radiuss-spack-configs and Spack versions. I also manually tested the below on tioga with Spack 1.1.0. The compiler in the spec used to work with Spack 1.0.2 but does not with 1.1.0. But the
hipblas-commonspack package actually does not depend on c/cxx so I think this is the correct fix.Before fix:
After fix: