Merged
Conversation
a44e1d3 to
09bb31f
Compare
09bb31f to
18cf423
Compare
… docker containers
Member
|
Heads up for you @chapman39 , Axom changed their default type for index: You will get a lot of warnings as errors. |
Closed
…ith into feature/chapman39/tpl-2025-12-15
chapman39
commented
Jan 13, 2026
white238
reviewed
Jan 16, 2026
| version: [7.2.6] | ||
| externals: | ||
| - spec: py-sphinx@7.2.6 | ||
| - spec: py-sphinx@7.2.6 ^python |
Collaborator
Author
There was a problem hiding this comment.
i forget the exact error, but spack wasn't concretizing without this.
white238
reviewed
Jan 16, 2026
| prefix: /usr | ||
| openblas: | ||
| buildable: false | ||
| # Spack is insistent on building openblas in the CUDA container, so allow building from source |
Member
There was a problem hiding this comment.
Should this be removed then? Why have an external when we are building it?
Collaborator
Author
There was a problem hiding this comment.
i believe non-cuda containers were finding openblas, which is why i figured i'd leave the external path just in case.
white238
reviewed
Jan 16, 2026
white238
reviewed
Jan 16, 2026
white238
reviewed
Jan 16, 2026
white238
reviewed
Jan 16, 2026
white238
reviewed
Jan 16, 2026
white238
reviewed
Jan 16, 2026
white238
reviewed
Jan 16, 2026
white238
approved these changes
Jan 16, 2026
Member
white238
left a comment
There was a problem hiding this comment.
All my comments were nitpicking and I don't want to hold up this being merged after someone else's review. Thanks for the hard slog @chapman39 !
tupek2
approved these changes
Jan 16, 2026
Co-authored-by: Chris White <white238@llnl.gov>
Co-authored-by: Chris White <white238@llnl.gov>
…ith into feature/chapman39/tpl-2025-12-15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pr
componentsvariant to Axom's spack package axom#1740about CUDA
related PRs
next
Fixes #1525