Grab bag of changes for Blast, incl. Axom update#333
Draft
Grab bag of changes for Blast, incl. Axom update#333
Conversation
added 7 commits
February 12, 2024 19:16
This reverts commit b990b4d.
jmpearl
reviewed
Feb 28, 2025
brbass
commented
May 20, 2025
brbass
commented
May 20, 2025
src/CRKSPH/CRKSPH.cc
Outdated
Comment on lines
92
to
100
| //------------------------------------------------------------------------------ | ||
| // Destructor. | ||
| //------------------------------------------------------------------------------ | ||
| template<typename Dimension> | ||
| CRKSPH<Dimension>:: | ||
| ~CRKSPH(){ | ||
| // Needs to be here due to implicit PairwiseField delete | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Had to add this to all the hydro packages. Otherwise, the build fails since the PairwiseField destructor isn't available in the header file.
added 3 commits
May 21, 2025 14:34
brbass
changed the title
Closed
Collaborator
|
Is anything here still relevant and useful? |
Contributor
Author
This branch includes the changes needed to get spheral running smoothly in marbl. There are a few fixes to includes that were needed to build (PairwiseField) and a few features (different density sum in FSISPH and the ability to delete nodes). My guess is that marbl is still using a commit from this branch unless someone has updated it, so I would check with the marbl team to see what they would like to do. |
Collaborator
|
Got it. Thanks @brbass ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR does a few things:
The Axom updates include fixes from the version that Kenny posted earlier, so those should be disregarded.
ToDo :
RELEASE_NOTES.mdwith notable changes.