You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Also, would it be possible to add tests for just FlatConnectivity independent of the solvers?
Yes, good call. FlatConnectivity was originally added along with the KernelIntegrator and is also tested there, but it would be good to make sure it's working correctly on its own!
Also, would it be possible to add tests for just FlatConnectivity independent of the solvers?
Yes, good call. FlatConnectivity was originally added along with the KernelIntegrator and is also tested there, but it would be good to make sure it's working correctly on its own!
I added the test for FlatConnectivity to the other PR where I modified it. You can find it there!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds linear solvers to Spheral. This supersedes the previous PR (#346), which was inefficient in both the matrix fill and factorization.
The basic usage of these new solvers is:
initializeto create the matrices and vectorsbeginFillsetMatRowsor by row withsetMatRowassemblewhen fill is complete to assemble the matrixfinalizeafter assembly to create solvers and preconditionerssetsolveormultiplygetThis PR probably depends on and should be merged after #405 due to the changes to
FlatConnectivity.ToDo :
RELEASE_NOTES.mdwith notable changes.