Draft
Conversation
Replace obsolete "spack concretize -U" with spack:concretizer:reuse:false to disable it by default within our build environment. Move compiler definitions from compilers.yaml to packages.yaml since compilers.yaml is obsolete in v1.0 Update specs to handle new semantics for "%" in v1.0 Updated using packages to point to new, separate package repository for spack. Added "depends_on" for package language dependencies (c, cxx, fortran) Renamed "m-aneos" package to "m_aneos" to match new package naming requirements of spack v1.0
Collaborator
Author
|
…, added c and cxx dependencies for packages missing them, added fortran dependency to spheral to avoid known spack bug, python concretize function is called instead of SpackCommand
mcfadden8
commented
Oct 27, 2025
mcfadden8
commented
Oct 27, 2025
mcfadden8
commented
Oct 27, 2025
…or tpl-manager.py
becker33
reviewed
Oct 30, 2025
Member
becker33
left a comment
becker33
left a comment
There was a problem hiding this comment.
Commeting everything I noticed while looking for the issue we were discussing on slack for setting the working dir.
…o package names are maintained by spack
…m-amdgpu, added llvm-amdgpu package recipe
Signed-off-by: Gregory Becker <becker33@llnl.gov>
Updated package directory names and spec name to follow spack v1.1 naming requirements
mcfadden8
changed the title
…added environment variable settings for the llvm-amdgpu package recipe
…ed the c, cxx, and fortran depends_on below variants in package recipe, added ~fortran variant to silo
…nvironment variable
ldowen
reviewed
Jan 9, 2026
| # `spack clean -a`, so it is important that the specified directory uniquely | ||
| # identifies Spack staging to avoid accidentally wiping out non-Spack work. | ||
| misc_cache: $spack/../misc_cache | ||
| test_stage: $spack/../test_stage |
Collaborator
There was a problem hiding this comment.
We also should add:
source_cache: $spack/../source_cache
ldowen
reviewed
Jan 9, 2026
| os.rename(orig_file, os.path.join(self.spack_env.path, "spack.yaml")) | ||
| if self.args.update_upstream: | ||
| upstream_dir = spack.config.get("upstreams:spheral_shared:install_tree") | ||
| with spack.config.override("config:install_tree", upstream_dir): |
Collaborator
There was a problem hiding this comment.
This should be changed to:
with spack.config.override("config", {"install_tree": {"root": str(upstream_dir)}}):
to work. Also, removed packages that are no longer necessary since their versions are now in the spack builtins.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor configuration and build scripts to use spack v1.0.2
spack concretize -Uwithspack:concretizer:reuse:falseto disable it by default within our build environment.ToDo :