Bugfix: CVODE(S) Inequality Constraints #787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drreynolds
reviewed
Jan 7, 2026
balos1
previously approved these changes
Jan 9, 2026
Steven-Roberts
previously approved these changes
Jan 10, 2026
drreynolds
previously approved these changes
Jan 13, 2026
gardner48
added a commit
to sundials-codes/answers
that referenced
this pull request
Jan 22, 2026
Update output files for llnl/sundials#787
gardner48
dismissed stale reviews from drreynolds, Steven-Roberts, and balos1
via
b350704
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug in the CVODE(S) inequality constraint handling where the predicted state was used to compute the step size reduction factor instead of the prior solution which could lead to an incorrect reduction in the step size or, when the prediction violates the constraints, an infinitely large step size in the next step attempt. (Fixes #702)
Add a unit test for inequality constraint handling with all the integrators.
In CVODE(S) and IDA(S), separate inequality constraint check from the nonlinear solve check.
Add functions to set the maximum number of inequality constraint failures and get total number of failures (constraint failures are no longer included in the number of step failures due to a solver failure).
Add a function to get the number of steps modified but not failed due to constraint violations.
Synchronize some differences between CVODE/CVODES and IDA/IDAS source and docs.
Add missing return flag names to
CVodeGetReturnFlagNamein CVODES andIDAGetReturnFlagNamein IDA.