Open
Conversation
…urrent stage solution, and to only call RHS on that vector
drreynolds
requested review from
balos1,
cswoodward and
gardner48
as code owners
Collaborator
Author
|
This is the third in a sequence of PRs for ARKODE to support our FES collaborators. Please review this one after #814. When the stack is complete, we'll do a final PR into |
Collaborator
Author
|
This PR should be ready to review -- all CI issues resulting from the new release have been resolved. |
…the evolving stage solution, as requested during PR review
…ep and when 'Reset' will be called thereafter
…fixed step and when 'Reset' will be called thereafter" This reverts commit 33380c2.
maggul
reviewed
Mar 2, 2026
maggul
reviewed
Mar 2, 2026
maggul
reviewed
Mar 2, 2026
maggul
reviewed
Mar 2, 2026
maggul
reviewed
Mar 2, 2026
maggul
reviewed
Mar 2, 2026
Co-authored-by: Mustafa Ağgül <33010171+maggul@users.noreply.github.com>
maggul
approved these changes
Mar 4, 2026
gardner48
requested changes
Mar 16, 2026
|
|
||
| The variables (ark_mem->tcur, ark_mem->ycur) should | ||
| contain the current time and solution at each stage within | ||
| the time step. |
Member
There was a problem hiding this comment.
Removing the copy in #813 to update ycur with yn will require some updates below to revert ycur back to yn (looks like just the first RHS call at the start of a step)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General LSRKStep cleanup, including always using (tcur,ycur) as the current stage solution, and to only call RHS on that vector.