Fixes incorrect lower bound for integers (#130)#251
Open
jbinary wants to merge 2 commits intolloyd:masterfrom
Open
Fixes incorrect lower bound for integers (#130)#251jbinary wants to merge 2 commits intolloyd:masterfrom
jbinary wants to merge 2 commits intolloyd:masterfrom
Conversation
The yajl_parse_integer() routine sets the errno to ERANGE if the string "-9223372036854775808", even though this value is still representable as a long long
during the fix of correctly parsing LLONG_MIN value I added a bug when a number having all the first numbers coniciding with LLONG_MIN but also having more numbers, like -92233720368547758080 would not raise an exception as expected this fix uses the bigger half, which is negative to compute the number instead, so there's no initial issue when we just can't hold enough numbers in our number space
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The yajl_parse_integer() routine sets the errno to ERANGE if the string "-9223372036854775808", even though this value is still representable as a long long