Skip to content

Commit de8566f

Browse files
committed
[Support] No ";" in CIRCT_DEBUG_SCOPED_PASS_LOGGER
Drop the trailing semicolon after the `CIRCT_DEBUG_SCOPED_PASS_LOGGER`. This better aligns with other debug macros. h/t @rwy7 for the suggestion. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
1 parent 24a996c commit de8566f

19 files changed

+20
-20
lines changed

include/circt/Support/Debug.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,11 +68,11 @@ class ScopedDebugPassLogger {
6868
};
6969

7070
#define CIRCT_DEBUG_SCOPED_PASS_LOGGER(PASS) \
71-
ScopedDebugPassLogger _scopedDebugPassLogger(PASS);
71+
ScopedDebugPassLogger _scopedDebugPassLogger(PASS)
7272
#else
7373
#define CIRCT_DEBUG_SCOPED_PASS_LOGGER(PASS) \
7474
do { \
75-
} while (0);
75+
} while (0)
7676
#endif
7777

7878
} // namespace circt

lib/Dialect/FIRRTL/Transforms/AssignOutputDirs.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ struct AssignOutputDirsPass
8484
} // namespace
8585

8686
void AssignOutputDirsPass::runOnOperation() {
87-
CIRCT_DEBUG_SCOPED_PASS_LOGGER(this)
87+
CIRCT_DEBUG_SCOPED_PASS_LOGGER(this);
8888
SmallString<64> outputDir(outputDirOption);
8989
if (fs::make_absolute(outputDir)) {
9090
emitError(mlir::UnknownLoc::get(&getContext()),

lib/Dialect/FIRRTL/Transforms/BlackBoxReader.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ struct BlackBoxReaderPass
122122

123123
/// Emit the annotated source code for black boxes in a circuit.
124124
void BlackBoxReaderPass::runOnOperation() {
125-
CIRCT_DEBUG_SCOPED_PASS_LOGGER(this)
125+
CIRCT_DEBUG_SCOPED_PASS_LOGGER(this);
126126
CircuitOp circuitOp = getOperation();
127127
CircuitNamespace ns(circuitOp);
128128

lib/Dialect/FIRRTL/Transforms/EliminateWires.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ struct EliminateWiresPass
4747
} // end anonymous namespace
4848

4949
void EliminateWiresPass::runOnOperation() {
50-
CIRCT_DEBUG_SCOPED_PASS_LOGGER(this)
50+
CIRCT_DEBUG_SCOPED_PASS_LOGGER(this);
5151

5252
auto module = getOperation();
5353
auto &dominance = getAnalysis<mlir::DominanceInfo>();

lib/Dialect/FIRRTL/Transforms/GrandCentral.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1809,7 +1809,7 @@ GrandCentralPass::getEnclosingModule(Value value, FlatSymbolRefAttr sym) {
18091809

18101810
/// This method contains the business logic of this pass.
18111811
void GrandCentralPass::runOnOperation() {
1812-
CIRCT_DEBUG_SCOPED_PASS_LOGGER(this)
1812+
CIRCT_DEBUG_SCOPED_PASS_LOGGER(this);
18131813

18141814
CircuitOp circuitOp = getOperation();
18151815

lib/Dialect/FIRRTL/Transforms/IMDeadCodeElim.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -313,7 +313,7 @@ void IMDeadCodeElimPass::forwardConstantOutputPort(FModuleOp module) {
313313
}
314314

315315
void IMDeadCodeElimPass::runOnOperation() {
316-
CIRCT_DEBUG_SCOPED_PASS_LOGGER(this)
316+
CIRCT_DEBUG_SCOPED_PASS_LOGGER(this);
317317

318318
auto circuits = getOperation().getOps<CircuitOp>();
319319
if (circuits.empty())

lib/Dialect/FIRRTL/Transforms/InjectDUTHierarchy.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ static void addHierarchy(hw::HierPathOp path, FModuleOp dut,
131131
}
132132

133133
void InjectDUTHierarchy::runOnOperation() {
134-
CIRCT_DEBUG_SCOPED_PASS_LOGGER(this)
134+
CIRCT_DEBUG_SCOPED_PASS_LOGGER(this);
135135

136136
CircuitOp circuit = getOperation();
137137

lib/Dialect/FIRRTL/Transforms/LayerSink.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -478,7 +478,7 @@ struct LayerSinkPass final
478478
} // namespace
479479

480480
void LayerSinkPass::runOnOperation() {
481-
CIRCT_DEBUG_SCOPED_PASS_LOGGER(this)
481+
CIRCT_DEBUG_SCOPED_PASS_LOGGER(this);
482482

483483
auto circuit = getOperation();
484484
LLVM_DEBUG(llvm::dbgs() << "Circuit: '" << circuit.getName() << "'\n");

lib/Dialect/FIRRTL/Transforms/LowerAnnotations.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1210,7 +1210,7 @@ LogicalResult LowerAnnotationsPass::solveWiringProblems(ApplyState &state) {
12101210

12111211
// This is the main entrypoint for the lowering pass.
12121212
void LowerAnnotationsPass::runOnOperation() {
1213-
CIRCT_DEBUG_SCOPED_PASS_LOGGER(this)
1213+
CIRCT_DEBUG_SCOPED_PASS_LOGGER(this);
12141214

12151215
CircuitOp circuit = getOperation();
12161216
SymbolTable modules(circuit);

lib/Dialect/FIRRTL/Transforms/LowerOpenAggs.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -835,7 +835,7 @@ struct LowerOpenAggsPass
835835

836836
// This is the main entrypoint for the lowering pass.
837837
void LowerOpenAggsPass::runOnOperation() {
838-
CIRCT_DEBUG_SCOPED_PASS_LOGGER(this)
838+
CIRCT_DEBUG_SCOPED_PASS_LOGGER(this);
839839

840840
SmallVector<Operation *, 0> ops(getOperation().getOps<FModuleLike>());
841841

0 commit comments

Comments
 (0)