Add HeaderInsertion config option
#129
Conversation
HighCommander4
left a comment
HighCommander4
left a comment
There was a problem hiding this comment.
Thanks for the doc patch. Looks good with two corrections.
config.md
Outdated
| Completion: | ||
| AllScopes: Yes | ||
| ArgumentLists: FullPlaceholders | ||
| HeaderInsertion: Never |
There was a problem hiding this comment.
I assume by "sample block (default)" you mean that you want to list the defaults here.
The default for HeaderInsertion is IWYU.
There was a problem hiding this comment.
Ah whoops! Fixed it.
config.md
Outdated
| the delimiters are `<>`. | ||
|
|
||
| ### HeaderInsertion | ||
| {:.v20} |
There was a problem hiding this comment.
This config option will actually first appear in clangd 21. (llvm 20 has branched in January, so any commits more recent than that target llvm 21 unless they are explicitly backported to the llvm 20 branch.)
There was a problem hiding this comment.
Ah I didn't realize, 20 had already released, thanks! Should be fixed now.
|
I just now noticed that the default blocks use 2 spaces for indent, whereas my commit has 4 😅 . Should I update the PR with a fix, for consistency? |
Sure (but note that you can't reopen a merged PR, you need to submit a new one) |
|
Done, sorry for the trouble and thank you for your time! |
2 participants
Add config documentation for
HeaderInsertion, introduced in this PR.Also added a commit for the default sample block. If this needs to go in a separate PR, let me know!