[CIR][ABI][AArch64][Lowering] Support structures with padding #1118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcardosolopes
requested changes
Nov 13, 2024
Member
bcardosolopes
left a comment
bcardosolopes
left a comment
There was a problem hiding this comment.
Great! Content LGTM, some minor nits before approval
clang/lib/CIR/Dialect/Transforms/TargetLowering/RecordLayoutBuilder.cpp
Outdated
Show resolved
Hide resolved
clang/lib/CIR/Dialect/Transforms/TargetLowering/LowerFunction.cpp
Outdated
Show resolved
Hide resolved
bcardosolopes
requested changes
Nov 14, 2024
clang/lib/CIR/Dialect/Transforms/TargetLowering/RecordLayoutBuilder.cpp
Outdated
Show resolved
Hide resolved
keryell
reviewed
Nov 15, 2024
| S_PAD ret_s_pad() { | ||
| S_PAD s; | ||
| return s; | ||
| } |
bcardosolopes
approved these changes
Nov 19, 2024
bruteforceboy
added a commit
to bruteforceboy/clangir
that referenced
this pull request
Nov 25, 2024
) The title describes the purpose of the PR. It adds initial support for structures with padding to the call convention lowering for AArch64. I have also _initial support_ for the missing feature [FinishLayout](https://github.com/llvm/clangir/blob/5c5d58402bebdb1e851fb055f746662d4e7eb586/clang/lib/AST/RecordLayoutBuilder.cpp#L786) for records, and the logic is gotten from the original codegen. Finally, I added a test for verification.
lanza
pushed a commit
that referenced
this pull request
Mar 18, 2025
The title describes the purpose of the PR. It adds initial support for structures with padding to the call convention lowering for AArch64. I have also _initial support_ for the missing feature [FinishLayout](https://github.com/llvm/clangir/blob/5c5d58402bebdb1e851fb055f746662d4e7eb586/clang/lib/AST/RecordLayoutBuilder.cpp#L786) for records, and the logic is gotten from the original codegen. Finally, I added a test for verification.
terapines-osc-cir
pushed a commit
to Terapines/clangir
that referenced
this pull request
Sep 2, 2025
) The title describes the purpose of the PR. It adds initial support for structures with padding to the call convention lowering for AArch64. I have also _initial support_ for the missing feature [FinishLayout](https://github.com/llvm/clangir/blob/5c5d58402bebdb1e851fb055f746662d4e7eb586/clang/lib/AST/RecordLayoutBuilder.cpp#L786) for records, and the logic is gotten from the original codegen. Finally, I added a test for verification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The title describes the purpose of the PR. It adds initial support for structures with padding to the call convention lowering for AArch64.
I have also initial support for the missing feature FinishLayout for records, and the logic is gotten from the original codegen.
Finally, I added a test for verification.