Skip to content

Conversation

@seven-mile
Copy link
Collaborator

Currently, the final target triple in LLVM IR is set in CIRGenAction, which is not executed by cir tools like cir-translate. This PR delay its assignment to LLVM lowering, enabling sharing the emitting of target triple between different invoking paths.

@seven-mile
Copy link
Collaborator Author

A series of patches will be made to improve the triple and data layout in ClangIR, and this is the first one. The next steps are as follows:

  • Remove the redundancy between dlti.dl_spec and llvm.data_layout in CIR, with the LLVM one being removed.
  • Depending on the upstream PR llvm-project#116090, add the --target option to cir-translate / cir-opt and relieve us from the horror of manually specifying data layout in our tests.

@bcardosolopes bcardosolopes merged commit 5548546 into llvm:main Nov 14, 2024
7 checks passed
lanza pushed a commit that referenced this pull request Mar 18, 2025
Currently, the final `target triple` in LLVM IR is set in
`CIRGenAction`, which is not executed by cir tools like `cir-translate`.
This PR delay its assignment to LLVM lowering, enabling sharing the
emitting of `target triple` between different invoking paths.
terapines-osc-cir pushed a commit to Terapines/clangir that referenced this pull request Sep 2, 2025
…1125)

Currently, the final `target triple` in LLVM IR is set in
`CIRGenAction`, which is not executed by cir tools like `cir-translate`.
This PR delay its assignment to LLVM lowering, enabling sharing the
emitting of `target triple` between different invoking paths.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants