[CIR] Add support for SourceLocExpr (__builtin_LINE, etc.) #1988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanza
requested review from
andykaylor,
bcardosolopes and
xlauko
as code owners
Member
bcardosolopes
left a comment
bcardosolopes
left a comment
There was a problem hiding this comment.
LGTM with one minor nit!
| @@ -0,0 +1,73 @@ | |||
| // RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -std=c++20 -fclangir -emit-cir %s -o %t.cir | |||
| // RUN: FileCheck --input-file=%t.cir %s | |||
Member
There was a problem hiding this comment.
Please add LLVM and OGCG checks too!
Member
|
The windows failure seems exposed after rebase, we should probably REQUIRES linux / darwin for it right now |
lanza
added a commit
that referenced
this pull request
Nov 20, 2025
This patch implements SourceLocExpr code generation, which enables support for the following builtin functions: - __builtin_LINE - __builtin_FILE - __builtin_FUNCTION - __builtin_COLUMN These builtins are evaluated at compile-time and emit constant values or global string literals. The implementation follows the traditional CodeGen approach of using ConstantEmitter to emit abstract constants from evaluated APValues. A key challenge was handling synthetic StringLiterals created during constant evaluation (for __builtin_FILE and __builtin_FUNCTION). These synthetic literals don't have valid source locations, which caused assertion failures when creating global string constants. The fix adds a check in getGlobalForStringLiteral to use UnknownLoc when the StringLiteral has an invalid source range. This feature unblocks: - std::source_location (C++20) - Logging and debugging macros that use source location builtins - Assertion/diagnostic frameworks Test coverage includes: - Basic __builtin_LINE, __builtin_FILE, __builtin_FUNCTION, __builtin_COLUMN - Usage in global variable initializers - Default function arguments - Lambda expressions - Combined usage of multiple source location builtins ghstack-source-id: 1958776 Pull-Request: #1988
lanza
added a commit
that referenced
this pull request
Nov 20, 2025
This patch implements SourceLocExpr code generation, which enables support for the following builtin functions: - __builtin_LINE - __builtin_FILE - __builtin_FUNCTION - __builtin_COLUMN These builtins are evaluated at compile-time and emit constant values or global string literals. The implementation follows the traditional CodeGen approach of using ConstantEmitter to emit abstract constants from evaluated APValues. A key challenge was handling synthetic StringLiterals created during constant evaluation (for __builtin_FILE and __builtin_FUNCTION). These synthetic literals don't have valid source locations, which caused assertion failures when creating global string constants. The fix adds a check in getGlobalForStringLiteral to use UnknownLoc when the StringLiteral has an invalid source range. This feature unblocks: - std::source_location (C++20) - Logging and debugging macros that use source location builtins - Assertion/diagnostic frameworks Test coverage includes: - Basic __builtin_LINE, __builtin_FILE, __builtin_FUNCTION, __builtin_COLUMN - Usage in global variable initializers - Default function arguments - Lambda expressions - Combined usage of multiple source location builtins ghstack-source-id: 1958776 Pull-Request: #1988
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This patch implements SourceLocExpr code generation, which enables
support for the following builtin functions:
These builtins are evaluated at compile-time and emit constant values
or global string literals. The implementation follows the traditional
CodeGen approach of using ConstantEmitter to emit abstract constants
from evaluated APValues.
A key challenge was handling synthetic StringLiterals created during
constant evaluation (for __builtin_FILE and __builtin_FUNCTION).
These synthetic literals don't have valid source locations, which
caused assertion failures when creating global string constants.
The fix adds a check in getGlobalForStringLiteral to use
UnknownLoc when the StringLiteral has an invalid source range.
This feature unblocks:
Test coverage includes: