[CIR] Add support for FileScopeAsm #1995
Conversation
| appendModuleInlineAsm(D->getAsmString()); | ||
| } | ||
|
|
||
| void CIRGenModule::finalizeModuleAttributes() { |
There was a problem hiding this comment.
Name might be too generic. Should I rename it to something more specific?
| // Handle module-level inline assembly | ||
| if (auto moduleAsmAttr = | ||
| mlir::dyn_cast<cir::ModuleAsmAttr>(attribute.getValue())) { | ||
| mlir::ArrayAttr asmStrings = moduleAsmAttr.getAsmStrings(); | ||
| for (mlir::Attribute attr : asmStrings) { | ||
| if (auto strAttr = mlir::dyn_cast<mlir::StringAttr>(attr)) { | ||
| llvmModule->appendModuleInlineAsm(strAttr.getValue()); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Does it make sense to place the lowering here or is there another place you guys prefer?
wizardengineer
force-pushed
the
julius/filescopeasm-impl
branch
from
2ff14fa to
0b01e1c
Compare
wizardengineer
force-pushed
the
julius/filescopeasm-impl
branch
from
0b01e1c to
e01ecbf
Compare
wizardengineer
requested review from
andykaylor,
bcardosolopes,
lanza and
xlauko
as code owners
bcardosolopes
left a comment
bcardosolopes
left a comment
There was a problem hiding this comment.
Thanks for improving this, comments inline
| } | ||
|
|
||
| //===----------------------------------------------------------------------===// | ||
| // FileScopeAsm |
| break; | ||
| } | ||
| case Decl::FileScopeAsm: | ||
| buildFileScopeAsm(cast<FileScopeAsmDecl>(decl)); |
There was a problem hiding this comment.
Please follow OG skeleton:
case Decl::FileScopeAsm:
// File-scope asm is ignored during device-side CUDA compilation.
if (langOpts.CUDA && langOpts.CUDAIsDevice)
break;
// File-scope asm is ignored during device-side OpenMP compilation.
if (langOpts.OpenMPIsTargetDevice)
break;
// File-scope asm is ignored during device-side SYCL compilation.
if (langOpts.SYCLIsDevice)
break;
buildFileScopeAsm(cast<FileScopeAsmDecl>(decl));
break;
}
| break; | ||
| } | ||
| case Decl::FileScopeAsm: | ||
| buildFileScopeAsm(cast<FileScopeAsmDecl>(decl)); |
There was a problem hiding this comment.
Just call moduleAsm.push_back(Asm.str()); directly here, the two levels of indirection are not providing any benefits right now
| } | ||
|
|
||
| // Finalize module attributes (including inline assembly) | ||
| finalizeModuleAttributes(); |
There was a problem hiding this comment.
OG doesn't do this right here, why are we? There's already other model level attributes being handled, the content of this function should be there
| // LLVM: module asm ".section .rodata" | ||
| // LLVM: module asm ".string {{\\22}}hello{{\\22}}" | ||
|
|
||
| // LLVM: define{{.*}} i32 @foo() |
There was a problem hiding this comment.
Look for OGCG in other tests and add the similar here.
2 participants
No description provided.