Run Tox tests in the Github Action CI #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldionne
force-pushed
the
review/run-tox-py3
branch
3 times, most recently
from
ce3f2ad to
658a91d
Compare
This patch enables running the Tox tests in Github Actions CI. It also adds some dependencies required to run the tests locally with Tox. An important change is that we move from LLVM's FileCheck implementation to a near-equivalent Python version that can be installed with pip. This will make the test suite more independent and easier to run: requiring a full LLVM monorepo checkout and a configured LLVM build just to run the LNT unit tests seems like a very cumbersome requirement. Also, this updates the documentation to reflect my current understanding of how the test suite can be run. Note that the tests are not passing at the moment, we will need to update some dependencies and fix other issues. But this gets us closer to running them, and at least we can see the progress being made in the CI.
ldionne
force-pushed
the
review/run-tox-py3
branch
from
0d65a62 to
8b31c9a
Compare
jroelofs
approved these changes
Oct 3, 2025
petrhosek
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch enables running the Tox tests in Github Actions CI.
It also adds some dependencies required to run the tests locally
with Tox.
An important change is that we move from LLVM's FileCheck
implementation to a near-equivalent Python version that can be
installed with pip. This will make the test suite more independent
and easier to run: requiring a full LLVM monorepo checkout and a
configured LLVM build just to run the LNT unit tests seems like a
very cumbersome requirement.
Also, this updates the documentation to reflect my current
understanding of how the test suite can be run.
Note that the tests are not passing at the moment, we will need to
update some dependencies and fix other issues. But this gets us
closer to running them, and at least we can see the progress being
made in the CI.