[tox] Fix a few invalid type annotations #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some type annotations are using nested types of the TestSuiteDB class. However, these nested types are actually defined in the __init__ method of TestSuiteDB and are hence not accessible as a class member. The easiest fix seems to be to downgrade these type annotations back to comments, at least for now. In a few other places, add missing annotations to make mypy happy and add `# noqa` to work around flake8 flagging imports as unused (when in reality they are required for mypy annotations). Finally, make the mypy test non-optional so it shows up as a failure when we break it. We are clearly missing a lot of annotations, but at least we have a basis that we can build upon and avoid regressing.
|
Verified locally that this fixes otherwise critically broken functionality and it makes the CI a bit "more green", so I'm merging. |
|
Thanks for fixing this. Bots are fine now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some type annotations are using nested types of the TestSuiteDB class. However, these nested types are actually defined in the init method of TestSuiteDB and are hence not accessible as a class member. The easiest fix seems to be to downgrade these type annotations back to comments, at least for now.
In a few other places, add missing annotations to make mypy happy and add
# noqato work around flake8 flagging imports as unused (when in reality they are required for mypy annotations).Finally, make the mypy test non-optional so it shows up as a failure when we break it. We are clearly missing a lot of annotations, but at least we have a basis that we can build upon and avoid regressing.