Draft
Conversation
The code representing reports (and related entities like machines, runs, etc) was greatly complicated by the presence of multiple input format versions. In particular, the "v2" input format was introduced but several parts of the codebase (e.g. `lnt importreport`) were never switched to it and were still producing reports in the "old" format. This patch simplifies the code by un-versionning the Python objects that represent Report-related entities and moving tests and other tools to produce the latest input format. However, old input formats are still supported in the sense that `lnt import` and the various importation methods still support old JSON formats, which are upgraded to the latest format before actually being submitted. TODO: - Fix tests that use the old input format (e.g. checked-in JSON files) - Look through anything that is still producing the old format (hint, search for elements of the old format like old classes e.g. TestSamples) - Fix remaining mentions of report_version - Look for other mentions of the report version format - Look through https://reviews.llvm.org/D65751 and https://reviews.llvm.org/D34584 - Add tests for the JSON upgrade from V1 to V2 instead of having all kinds of tests for each Python class - The new input format probably needs to make llvm_project_revision optional. It just doesn't make sense in most cases.
ldionne
force-pushed
the
review/cleanup-format-versions
branch
from
de8ab24 to
c568c9c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code representing reports (and related entities like machines, runs, etc) was greatly complicated by the presence of multiple input format versions.
In particular, the "v2" input format was introduced but several parts of the codebase (e.g.
lnt importreport) were never switched to it and were still producing reports in the "old" format.This patch simplifies the code by un-versionning the Python objects that represent Report-related entities and moving tests and other tools to produce the latest input format.
However, old input formats are still supported in the sense that
lnt importand the various importation methods still support old JSON formats, which areupgraded to the latest format before actually being submitted.
TODO: