Skip to content

Conversation

lukel97
Copy link
Contributor

@lukel97 lukel97 commented Oct 6, 2025

Mainly to match the Dockerfile image, but also so we can start testing other versions via a matrix

@lukel97 lukel97 merged commit 8b17183 into llvm:main Oct 6, 2025
1 of 3 checks passed
Copy link

@boomanaiden154 boomanaiden154 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the purpose of this? If we're shipping things in Docker, I don't see a need to support more than a single python version. Supporting more than one adds complexity, especially around dependency management.

@lukel97
Copy link
Contributor Author

lukel97 commented Oct 6, 2025

AFAIK very few people use the Dockerfile today, I'm trying to get the ball rolling on that though in #60 and #55. I have no idea what versions of Python downstream instances are using so I didn't want to remove the coverage for the existing version.

@boomanaiden154
Copy link

AFAIK very few people use the Dockerfile today, I'm trying to get the ball rolling on that though in #60 and #55. I have no idea what versions of Python downstream instances are using so I didn't want to remove the coverage for the existing version.

Ack. Is there a list of downstream users somewhere that we could contact? It would be nice to know constraints around versioning.

@lukel97
Copy link
Contributor Author

lukel97 commented Oct 6, 2025

AFAIK very few people use the Dockerfile today, I'm trying to get the ball rolling on that though in #60 and #55. I have no idea what versions of Python downstream instances are using so I didn't want to remove the coverage for the existing version.

Ack. Is there a list of downstream users somewhere that we could contact? It would be nice to know constraints around versioning.

cc) @DavidSpickett

FWIW I agree that it would be good to constrain the number of python versions supported. I think this is probably part of a larger chunk of work of modernizing all the dependencies and moving away from setup.py

@DavidSpickett
Copy link
Contributor

@antmox deals with our LNT server side.

I just care about the client, which is to run the test suite on the buildbots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants