[deps] Move dependency pins to requirements.txt #63
+26
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That way, we have a single place where all of our dependency versions are pinned, and setup.py only mentions which packages the tool depends on, without requiring specific versions. Also drop packages that are not depend upon directly from setup.py: some of those like `pytz` are still pinned in requirements.txt for stability, but they don't need to be in setup.py because we don't depend on them directly. The `six` package was dropped entirely since it wasn't used anymore. Finally, this patch pins the versions used when running `tox` by installing via requirements.txt, otherwise we end up using unpinned versions from setup.py when running the tests, which creates obvious issues.
boomanaiden154
approved these changes
Oct 6, 2025
Actually, I think that would probably replace our current |
fhahn
reviewed
Oct 7, 2025
fhahn
added a commit
that referenced
this pull request
Oct 7, 2025
Without pinned requirements, we end up installing incompatible versions of MarkupSafe and Jinja2. See #63 (review) For now, restore the pinned version before 47bc80b to unblock workflows using setup.py.
|
For now I restored the pinned versions in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That way, we have a single place where all of our dependency versions are pinned, and setup.py only mentions which packages the tool depends on, without requiring specific versions.
Also drop packages that are not depend upon directly from setup.py: some of those like
pytzare still pinned in requirements.txt for stability, but they don't need to be in setup.py because we don't depend on them directly. Thesixpackage was dropped entirely since it wasn't used anymore.Finally, this patch pins the versions used when running
toxby installing via requirements.txt, otherwise we end up using unpinned versions from setup.py when running the tests, which creates obvious issues.