Skip to content

Conversation

ldionne
Copy link
Member

@ldionne ldionne commented Oct 7, 2025

This patch unpins versions in setup.py since they are pinned in requirements.txt. This is effectively a revert of 11c2d9e and 8fc27f4.

When we originally unpinned versions from setup.py, some clients were running setup.py directly to install lnt, which means they started fetching untested and incompatible versions of packages.

Since then, we've documented the new installation procedure based on pip and our pinned requirements (in #70).

@ldionne ldionne requested review from fhahn and DavidSpickett October 7, 2025 15:08
@ldionne
Copy link
Member Author

ldionne commented Oct 7, 2025

(We should wait for #70 to land and for clients to be updated to use the pip installation instructions before landing)

Copy link
Contributor

@fhahn fhahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this still leave python setup.py develop broken?

I don't think this should broken by default. If there's no way to make this work, can we just remove them alltogether?

@ldionne
Copy link
Member Author

ldionne commented Oct 7, 2025

Does this still leave python setup.py develop broken?

I don't think this should broken by default. If there's no way to make this work, can we just remove them alltogether?

Well, it's not "broken" in the sense that python setup.py will install the module with the version of the dependencies specified in setup.py unversioned, which is the intent. However, that will result in a broken installation in 99.9% of the cases since you won't have appropriate versions of the dependencies.

As we update our dependencies to ones that aren't 10 years old and unsupported, python setup.py could very well start working again since the latest version of our dependencies should be usable. Right now the issue is that we have to pin ancient versions for anything to work.

Eventually, we can move away from setup.py and replace it by pyproject.toml which is the current best practice, but that should be done separately.

This patch unpins versions in setup.py since they are pinned in
requirements.txt. This is effectively a revert of 11c2d9e
and 8fc27f4.

When we originally unpinned versions from setup.py, some clients
were running `setup.py` directly to install `lnt`, which means
they started fetching untested and incompatible versions of
packages.

Since then, we've documented the new installation procedure based
on pip and our pinned requirements (in llvm#70).
@ldionne ldionne force-pushed the review/unpin-dependencies-from-setup branch from 084b02c to 388c0a7 Compare October 7, 2025 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants