Unpin versions in setup.py (2nd attempt) #71
+13
−23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch unpins versions in setup.py since they are pinned in requirements.txt. This is effectively a revert of 11c2d9e and 8fc27f4.
When we originally unpinned versions from setup.py, some clients were running
setup.py
directly to installlnt
, which means they started fetching untested and incompatible versions of packages.Since then, we've documented the new installation procedure based on pip and our pinned requirements (in #70).