Overhaul lnt updatedb
#80
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That command had a few issues, which I uncovered when I tried updating the Click dependency. First, it didn't specify the --delete-order parameter as being a multi-parameter, leading to the default value [] being interpreted as a string with value "[]", i.e. a non-empty string. This led to the tool always trying to delete an order with value "[]", which is nonsensical. For some reason, that only happens with newer Click version. This patch adds test coverage for --delete-order and makes it a multi valued parameter, which was obviously always the intent. It also improves the documentation for the various parameters, which was unclear in an attempt to be terse.
ldionne
commented
Oct 9, 2025
| @click.option("--database", default="default", show_default=True, | ||
| help="database to modify") | ||
| @click.option("--testsuite", required=True, help="testsuite to modify") | ||
| @click.option("--tmp-dir", default="lnt_tmp", show_default=True, |
There was a problem hiding this comment.
This was unused: probably copy-pasted from lnt create
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That command had a few issues, which I uncovered when I tried updating the Click dependency. First, it didn't specify the --delete-order parameter as being a multi-parameter, leading to the default value [] being interpreted as a string with value "[]", i.e. a non-empty string.
This led to the tool always trying to delete an order with value "[]", which is nonsensical. For some reason, that only happens with newer Click version.
This patch adds test coverage for --delete-order and makes it a multi valued parameter, which was obviously always the intent. It also improves the documentation for the various parameters, which was unclear in an attempt to be terse.