Skip to content

Commit 01d0e6f

Browse files
authored
Change bind to allow one callee descend.
1 parent 0ce25d1 commit 01d0e6f

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

clang-tools-extra/clang-tidy/llvm/UseNewMLIROpBuilderCheck.cpp

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -124,12 +124,13 @@ RewriteRuleWith<std::string> useNewMlirOpBuilderCheckRule() {
124124
"'builder.create<OpType>(...)'");
125125
// Match a create call on an OpBuilder.
126126
auto BuilderType = cxxRecordDecl(isSameOrDerivedFrom("::mlir::OpBuilder"));
127-
ast_matchers::internal::Matcher<Stmt> Base = cxxMemberCallExpr(
128-
on(expr(anyOf(hasType(BuilderType), hasType(pointsTo(BuilderType))))
129-
.bind("builder")),
130-
callee(expr().bind("call")),
131-
callee(cxxMethodDecl(hasTemplateArgument(0, templateArgument()),
132-
hasName("create"))));
127+
ast_matchers::internal::Matcher<Stmt> Base = =
128+
cxxMemberCallExpr(
129+
on(expr(anyOf(hasType(BuilderType), hasType(pointsTo(BuilderType))))
130+
.bind("builder")),
131+
callee(cxxMethodDecl(hasTemplateArgument(0, templateArgument()),
132+
hasName("create"))))
133+
.bind("call");
133134
return applyFirst(
134135
// Attempt rewrite given an lvalue builder, else just warn.
135136
{makeRule(cxxMemberCallExpr(unless(on(cxxTemporaryObjectExpr())), Base),

0 commit comments

Comments
 (0)