Skip to content

Commit 08d51b9

Browse files
committed
Removed redundant test commands and added comments to add.ll for the missing test
1 parent c2e9fb7 commit 08d51b9

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

llvm/lib/Target/AMDGPU/AMDGPURegBankLegalizeHelper.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -503,7 +503,8 @@ void RegBankLegalizeHelper::lowerUnpackMinMax(MachineInstr &MI) {
503503
void RegBankLegalizeHelper::lowerScalarizeV2S16(MachineInstr &MI) {
504504
auto CastOp1 = B.buildBitcast(SgprRB_S32, MI.getOperand(1).getReg());
505505
auto CastOp2 = B.buildBitcast(SgprRB_S32, MI.getOperand(2).getReg());
506-
auto NewInstr = B.buildInstr(MI.getOpcode(), {SgprRB_S32}, {CastOp1, CastOp2});
506+
auto NewInstr =
507+
B.buildInstr(MI.getOpcode(), {SgprRB_S32}, {CastOp1, CastOp2});
507508
B.buildBitcast({SgprRB, V2S16}, NewInstr.getReg(0));
508509
MI.eraseFromParent();
509510
}

llvm/test/CodeGen/AMDGPU/GlobalISel/add.ll

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -196,8 +196,9 @@ define i32 @v_add_i32(i32 %a, i32 %b) {
196196
ret i32 %c
197197
}
198198

199-
; TODO: Add test for s_add_v2i16. Instruction selector currently fails
200-
; to handle G_UNMERGE_VALUES. Same in GlobalISel/sub.ll.
199+
; TODO: Add test for s_add_v2i16. The current test does not work
200+
; due to a bug associated with
201+
; AMDGPURegBankLegalizeCombiner::tryEliminateReadAnyLane(..)
201202

202203
define <2 x i16> @v_add_v2i16(<2 x i16> %a, <2 x i16> %b) {
203204
; GFX7-LABEL: v_add_v2i16:

llvm/test/CodeGen/AMDGPU/GlobalISel/regbankselect-add.v2s16.mir

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
2-
# RUN: llc -mtriple=amdgcn -mcpu=gfx900 -run-pass=amdgpu-regbankselect,amdgpu-regbanklegalize %s -verify-machineinstrs -o - -regbankselect-fast | FileCheck %s
3-
# RUN: llc -mtriple=amdgcn -mcpu=gfx900 -run-pass=amdgpu-regbankselect,amdgpu-regbanklegalize %s -verify-machineinstrs -o - -regbankselect-greedy | FileCheck %s
2+
# RUN: llc -mtriple=amdgcn -mcpu=gfx900 -run-pass=amdgpu-regbankselect,amdgpu-regbanklegalize %s -verify-machineinstrs -o - | FileCheck %s
43

54
---
65
name: add_v2s16_ss

0 commit comments

Comments
 (0)