Apply review

Author: Andres-Salamanca

clang/lib/CIR/CodeGen/CIRGenRecordLayoutBuilder.cpp

@@ -92,7 +92,7 @@ struct CIRRecordLowering final {
   }
 
   /// Helper function to check if the target machine is BigEndian.
-  bool isBE() const { return astContext.getTargetInfo().isBigEndian(); }
+  bool isBigEndian() const { return astContext.getTargetInfo().isBigEndian(); }
 
   CharUnits bitsToCharUnits(uint64_t bitOffset) {
     return astContext.toCharUnitsFromBits(bitOffset);
@@ -789,7 +789,7 @@ void CIRRecordLowering::computeVolatileBitfields() {
     // of the type), we first undo that calculation here and redo it once
     // the bit-field offset within the new container is calculated.
     const unsigned oldOffset =
-        isBE() ? info.storageSize - (info.offset + info.size) : info.offset;
+        isBigEndian() ? info.storageSize - (info.offset + info.size) : info.offset;
     // Offset to the bit-field from the beginning of the struct.
     const unsigned absoluteOffset =
         astContext.toBits(info.storageOffset) + oldOffset;
@@ -811,7 +811,7 @@ void CIRRecordLowering::computeVolatileBitfields() {
       continue;
 
     // Re-adjust offsets for big-endian targets.
-    if (isBE())
+    if (isBigEndian())
       offset = storageSize - (offset + info.size);
 
     const CharUnits storageOffset =

clang/test/CIR/CodeGen/aapcs-volatile-bitfields.c

@@ -41,7 +41,7 @@ typedef struct{
     volatile unsigned int a : 3;
     unsigned int : 0; // zero-length bit-field force next field to aligned int boundary
     volatile unsigned int b : 5;
-}st3;
+} st3;
 
 // CIR-LAYOUT: BitFields:[
 // CIR-LAYOUT-NEXT:   <CIRBitFieldInfo name:a offset:0 size:3 isSigned:0 storageSize:8 storageOffset:0 volatileOffset:0 volatileStorageSize:32 volatileStorageOffset:0>
@@ -55,7 +55,7 @@ typedef struct{
     volatile unsigned int a : 3;
     unsigned int z: 2;
     volatile unsigned int b : 5;
-}st4;
+} st4;
 
 // CIR-LAYOUT: BitFields:[
 // CIR-LAYOUT-NEXT:   <CIRBitFieldInfo name:a offset:0 size:3 isSigned:0 storageSize:16 storageOffset:0 volatileOffset:0 volatileStorageSize:32 volatileStorageOffset:0>