add review changes.

da-viper · da-viper · commit 0f80c91a4fa8 · 2025-11-19T22:09:22.000Z
diff --git a/lldb/source/Plugins/Language/CPlusPlus/LibStdcppSpan.cpp b/lldb/source/Plugins/Language/CPlusPlus/LibStdcppSpan.cpp
@@ -82,12 +82,12 @@ class LibStdcppSpanSyntheticFrontEnd : public SyntheticChildrenFrontEnd {
   llvm::Expected<size_t> GetIndexOfChildWithName(ConstString name) override {
     if (!m_start)
       return llvm::createStringError(
-          llvm::formatv("Type has no child named {0}", name.AsCString()));
+          llvm::formatv("Type has no child named {0}", name.GetStringRef()));
 
     auto optional_idx = formatters::ExtractIndexFromString(name.GetCString());
     if (!optional_idx) {
       return llvm::createStringError(
-          llvm::formatv("Type has no child named {0}", name.AsCString()));
+          llvm::formatv("Type has no child named {0}", name.GetStringRef()));
     }
     return *optional_idx;
   }

Original file line number	Diff line number	Diff line change
`@@ -82,12 +82,12 @@ class LibStdcppSpanSyntheticFrontEnd : public SyntheticChildrenFrontEnd {`
`82`	`82`	`llvm::Expected<size_t> GetIndexOfChildWithName(ConstString name) override {`
`83`	`83`	`if (!m_start)`
`84`	`84`	`return llvm::createStringError(`
`85`		`- llvm::formatv("Type has no child named {0}", name.AsCString()));`
	`85`	`+ llvm::formatv("Type has no child named {0}", name.GetStringRef()));`
`86`	`86`
`87`	`87`	`auto optional_idx = formatters::ExtractIndexFromString(name.GetCString());`
`88`	`88`	`if (!optional_idx) {`
`89`	`89`	`return llvm::createStringError(`
`90`		`- llvm::formatv("Type has no child named {0}", name.AsCString()));`
	`90`	`+ llvm::formatv("Type has no child named {0}", name.GetStringRef()));`
`91`	`91`	`}`
`92`	`92`	`return *optional_idx;`
`93`	`93`	`}`