review: apply objcopy before validation

- DXC will invoke the validator after the final blob has been generated
(in this case after the part is removed)

Author: inbelic

clang/lib/Driver/Driver.cpp

@@ -4647,6 +4647,16 @@ void Driver::BuildDefaultActions(Compilation &C, DerivedArgList &Args,
     // Only add action when needValidation.
     const auto &TC =
         static_cast<const toolchains::HLSLToolChain &>(C.getDefaultToolChain());
+    if (TC.requiresObjcopy(Args)) {
+      Action *LastAction = Actions.back();
+      // llvm-objcopy expects a DXIL container, which can either be
+      // validated (in which case they are TY_DX_CONTAINER), or unvalidated
+      // (TY_OBJECT).
+      if (LastAction->getType() == types::TY_DX_CONTAINER ||
+          LastAction->getType() == types::TY_Object)
+        Actions.push_back(
+            C.MakeAction<ObjcopyJobAction>(LastAction, types::TY_DX_CONTAINER));
+    }
     if (TC.requiresValidation(Args)) {
       Action *LastAction = Actions.back();
       Actions.push_back(C.MakeAction<BinaryAnalyzeJobAction>(
@@ -4662,16 +4672,6 @@ void Driver::BuildDefaultActions(Compilation &C, DerivedArgList &Args,
         Actions.push_back(C.MakeAction<BinaryTranslatorJobAction>(
             LastAction, types::TY_DX_CONTAINER));
     }
-    if (TC.requiresObjcopy(Args)) {
-      Action *LastAction = Actions.back();
-      // llvm-objcopy expects a DXIL container, which can either be
-      // validated (in which case they are TY_DX_CONTAINER), or unvalidated
-      // (TY_OBJECT).
-      if (LastAction->getType() == types::TY_DX_CONTAINER ||
-          LastAction->getType() == types::TY_Object)
-        Actions.push_back(
-            C.MakeAction<ObjcopyJobAction>(LastAction, types::TY_DX_CONTAINER));
-    }
   }
 
   // Claim ignored clang-cl options.