Address review feedback

Author: mmha

clang/include/clang/CIR/Dialect/IR/CIROps.td

@@ -2230,6 +2230,7 @@ def CIR_ReturnAddrOp : CIR_FuncAddrBuiltinOp<"return_address"> {
     Represents a call to builtin function ` __builtin_return_address` in CIR.
     This builtin function returns the return address of the current function,
     or of one of its callers.
+
     The `level` argument is number of frames to scan up the call stack.
     For instance, value of 0 yields the return address of the current function,
     value of 1 yields the return address of the caller of the current function,

clang/lib/CIR/CodeGen/CIRGenBuiltin.cpp

@@ -315,15 +315,15 @@ RValue CIRGenFunction::emitBuiltinExpr(const GlobalDecl &gd, unsigned builtinID,
   case Builtin::BI__builtin_return_address:
   case Builtin::BI__builtin_frame_address: {
     mlir::Location loc = getLoc(e->getExprLoc());
-    mlir::Attribute levelAttr = ConstantEmitter(*this).emitAbstract(
-        e->getArg(0), e->getArg(0)->getType());
-    uint64_t level = mlir::cast<cir::IntAttr>(levelAttr).getUInt();
+    llvm::APSInt level = e->getArg(0)->EvaluateKnownConstInt(getContext());
     if (builtinID == Builtin::BI__builtin_return_address) {
-      return RValue::get(cir::ReturnAddrOp::create(builder,
-          loc, builder.getUInt32(level, loc)));
+      return RValue::get(cir::ReturnAddrOp::create(
+          builder, loc,
+          builder.getConstAPInt(loc, builder.getUInt32Ty(), level)));
     }
-    return RValue::get(
-        cir::FrameAddrOp::create(builder, loc, builder.getUInt32(level, loc)));
+    return RValue::get(cir::FrameAddrOp::create(
+        builder, loc,
+        builder.getConstAPInt(loc, builder.getUInt32Ty(), level)));
   }
 
   case Builtin::BI__builtin_trap:

clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp

@@ -273,8 +273,8 @@ createCallLLVMIntrinsicOp(mlir::ConversionPatternRewriter &rewriter,
                           mlir::Type resultTy, mlir::ValueRange operands) {
   auto intrinsicNameAttr =
       mlir::StringAttr::get(rewriter.getContext(), intrinsicName);
-  return mlir::LLVM::CallIntrinsicOp::create(rewriter,
-      loc, resultTy, intrinsicNameAttr, operands);
+  return mlir::LLVM::CallIntrinsicOp::create(rewriter, loc, resultTy,
+                                             intrinsicNameAttr, operands);
 }
 
 static mlir::LLVM::CallIntrinsicOp replaceOpWithCallLLVMIntrinsicOp(