Skip to content

Commit 4170922

Browse files
committed
Undo TLSDESC changes
For the moment, while the abi discussion continues.
1 parent 673cd14 commit 4170922

File tree

3 files changed

+4
-26
lines changed

3 files changed

+4
-26
lines changed

llvm/lib/Target/RISCV/MCTargetDesc/RISCVMCCodeEmitter.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -659,10 +659,6 @@ uint64_t RISCVMCCodeEmitter::getImmOpValue(const MCInst &MI, unsigned OpNo,
659659
break;
660660
case ELF::R_RISCV_GOT_HI20:
661661
case ELF::R_RISCV_TPREL_HI20:
662-
case ELF::R_RISCV_TLSDESC_HI20:
663-
case ELF::R_RISCV_TLSDESC_LOAD_LO12:
664-
case ELF::R_RISCV_TLSDESC_ADD_LO12:
665-
case ELF::R_RISCV_TLSDESC_CALL:
666662
RelaxCandidate = true;
667663
break;
668664
}

llvm/test/MC/RISCV/linker-relaxation.s

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,6 @@ auipc t1, %tlsdesc_hi(baz)
136136
# NORELAX-RELOC-NEXT: R_RISCV_TLSDESC_HI20 baz 0x0
137137
# NORELAX-RELOC-NOT: R_RISCV_RELAX
138138
# RELAX-RELOC-NEXT: R_RISCV_TLSDESC_HI20 baz 0x0
139-
# RELAX-RELOC-NEXT: R_RISCV_RELAX - 0x0
140139

141140
## %hi/%lo on an absolute symbol (not yet defined) leads to relocations when relaxation is enabled.
142141
lui t2, %hi(abs)

llvm/test/MC/RISCV/tlsdesc.s

Lines changed: 4 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,32 +1,18 @@
1-
# RUN: llvm-mc -filetype=obj -triple riscv32 < %s --defsym RV32=1 \
2-
# RUN: | llvm-objdump -dr -M no-aliases - \
3-
# RUN: | FileCheck %s --check-prefixes=INST,RV32
4-
# RUN: llvm-mc -filetype=obj -triple riscv64 < %s \
5-
# RUN: | llvm-objdump -dr -M no-aliases - \
6-
# RUN: | FileCheck %s --check-prefixes=INST,RV64
7-
# RUN: llvm-mc -filetype=obj -triple riscv32 -mattr=+relax < %s --defsym RV32=1 \
8-
# RUN: | llvm-objdump -dr -M no-aliases - \
9-
# RUN: | FileCheck %s --check-prefixes=INST,RV32,RELAX
10-
# RUN: llvm-mc -filetype=obj -triple riscv64 -mattr=+relax < %s \
11-
# RUN: | llvm-objdump -dr -M no-aliases - \
12-
# RUN: | FileCheck %s --check-prefixes=INST,RV64,RELAX
1+
# RUN: llvm-mc -filetype=obj -triple riscv32 < %s --defsym RV32=1 | llvm-objdump -dr -M no-aliases - | FileCheck %s --check-prefixes=INST,RV32
2+
# RUN: llvm-mc -filetype=obj -triple riscv64 < %s | llvm-objdump -dr -M no-aliases - | FileCheck %s --check-prefixes=INST,RV64
133

14-
# RUN: not llvm-mc -triple riscv32 < %s --defsym RV32=1 --defsym ERR=1 2>&1 \
15-
# RUN: | FileCheck %s --check-prefixes=ERR
16-
# RUN: not llvm-mc -triple riscv64 < %s --defsym ERR=1 2>&1 \
17-
# RUN: | FileCheck %s --check-prefixes=ERR
4+
# RUN: not llvm-mc -triple riscv32 < %s --defsym RV32=1 --defsym ERR=1 2>&1 | FileCheck %s --check-prefixes=ERR
5+
# RUN: not llvm-mc -triple riscv64 < %s --defsym ERR=1 2>&1 | FileCheck %s --check-prefixes=ERR
186

197
start: # @start
208
# %bb.0: # %entry
219
.Ltlsdesc_hi0:
2210
auipc a0, %tlsdesc_hi(a-4)
2311
# INST: auipc a0, 0x0
2412
# INST-NEXT: R_RISCV_TLSDESC_HI20 a-0x4
25-
# RELAX-NEXT: R_RISCV_RELAX
2613
auipc a0, %tlsdesc_hi(unspecified)
2714
# INST-NEXT: auipc a0, 0x0
2815
# INST-NEXT: R_RISCV_TLSDESC_HI20 unspecified
29-
# RELAX-NEXT: R_RISCV_RELAX
3016
.ifdef RV32
3117
lw a1, %tlsdesc_load_lo(.Ltlsdesc_hi0)(a0)
3218
# RV32: lw a1, 0x0(a0)
@@ -36,15 +22,12 @@ start: # @start
3622
# RV64: ld a1, 0x0(a0)
3723
# RV64-NEXT: R_RISCV_TLSDESC_LOAD_LO12 .Ltlsdesc_hi0
3824
.endif
39-
# RELAX-NEXT: R_RISCV_RELAX
4025
addi a0, a0, %tlsdesc_add_lo(.Ltlsdesc_hi0)
4126
# INST: addi a0, a0, 0x0
4227
# INST-NEXT: R_RISCV_TLSDESC_ADD_LO12 .Ltlsdesc_hi0
43-
# RELAX-NEXT: R_RISCV_RELAX
4428
jalr t0, 0(a1), %tlsdesc_call(.Ltlsdesc_hi0)
4529
# INST-NEXT: jalr t0, 0x0(a1)
4630
# INST-NEXT: R_RISCV_TLSDESC_CALL .Ltlsdesc_hi0
47-
# RELAX-NEXT: R_RISCV_RELAX
4831
add a0, a0, tp
4932
# INST-NEXT: add a0, a0, tp
5033
ret

0 commit comments

Comments
 (0)