Skip to content

Commit 4c0f90f

Browse files
committed
Update tests and comments
1 parent ee60009 commit 4c0f90f

File tree

8 files changed

+321
-628
lines changed

8 files changed

+321
-628
lines changed

llvm/lib/ObjCopy/COFF/COFFWriter.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ Error COFFWriter::finalizeSymIdxContents() {
112112
for (Symbol &Sym : Obj.getMutableSymbols()) {
113113
SymIdMap[Sym.OriginalRawIndex] = Sym.RawIndex;
114114

115-
// We collect only definition symbols of the sections to update checksum.
115+
// We collect only definition symbols of the sections to update the checksums.
116116
if (Sym.Sym.StorageClass == IMAGE_SYM_CLASS_STATIC &&
117117
Sym.Sym.NumberOfAuxSymbols == 1 && Sym.Sym.Value == 0 &&
118118
IsSymIdxSection(Sym.Name))
@@ -126,7 +126,7 @@ Error COFFWriter::finalizeSymIdxContents() {
126126
continue;
127127

128128
ArrayRef<uint8_t> RawIds = Sec.getContents();
129-
// Nothing to do and also CheckSum will be -1 instead of 0 if we recalculate
129+
// Nothing to do and also the checksum will be -1 instead of 0 if we recalculate
130130
// it on empty input.
131131
if (RawIds.size() == 0)
132132
continue;
@@ -154,7 +154,7 @@ Error COFFWriter::finalizeSymIdxContents() {
154154
}
155155
ArrayRef<uint8_t> NewRawIds(reinterpret_cast<uint8_t *>(NewIds.data()),
156156
RawIds.size());
157-
// Update check sum.
157+
// Update the checksum.
158158
JamCRC JC(/*Init=*/0);
159159
JC.update(NewRawIds);
160160
SecDefIt->getSecond()->CheckSum = JC.getCRC();

llvm/test/tools/llvm-objcopy/COFF/strip-invalid-symidx-section-1.test

Lines changed: 0 additions & 75 deletions
This file was deleted.

llvm/test/tools/llvm-objcopy/COFF/strip-invalid-symidx-section-2.test

Lines changed: 0 additions & 95 deletions
This file was deleted.

llvm/test/tools/llvm-objcopy/COFF/strip-invalid-symidx-section-3.test

Lines changed: 0 additions & 86 deletions
This file was deleted.

0 commit comments

Comments
 (0)