Skip to content

Commit 4c17749

Browse files
committed
[lldb][yaml2macho-core] change the two API tests to skipUnlessDarwin
These two 32-bit macho corefile tests are still failing on the lldb-remote-linux-win bot, I'd expect the @skipIfWindows decorator to skip the tests there until I can debug this, but somehow because it's a remote windows execution it's not working. Change these tests back to skipUnlessDarwin until I can figure out whether it's yaml2macho-core or lldb's 32-bit mach-o corefile reader support on windows which is the problem.
1 parent 0553f5a commit 4c17749

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

lldb/test/API/macosx/arm-corefile-regctx/TestArmMachoCorefileRegctx.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
class TestArmMachoCorefileRegctx(TestBase):
1414
NO_DEBUG_INFO_TESTCASE = True
1515

16-
@skipIfWindows # CI fail on Windows, lr has value 0x0F000000?
16+
@skipUnlessDarwin # CI fail on Windows, lr has value 0x0F000000?
1717
def test_armv7_corefile(self):
1818
### Create corefile
1919
corefile = self.getBuildArtifact("core")

lldb/test/API/macosx/riscv32-corefile/TestRV32MachOCorefile.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
class TestRV32MachOCorefile(TestBase):
1414
NO_DEBUG_INFO_TESTCASE = True
1515

16-
@skipIfWindows # windows CI failure, says only 1 thread in corefile
16+
@skipunlessDarwin # windows CI failure, says only 1 thread in corefile
1717
@no_debug_info_test
1818
def test_riscv32_gpr_corefile_registers(self):
1919
corefile = self.getBuildArtifact("core")

0 commit comments

Comments
 (0)