Skip to content

Commit 4fddfaf

Browse files
committed
Update tests and variable uses for new names, format
1 parent e5b6c36 commit 4fddfaf

File tree

3 files changed

+18
-16
lines changed

3 files changed

+18
-16
lines changed

llvm/test/tools/llvm-original-di-preservation/error-test.test renamed to llvm/test/tools/llvm-original-di-preservation/acceptance-test.test

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
RUN: not %llvm-original-di-preservation %p/Inputs/sample.json --error-test | FileCheck %s
1+
RUN: not %llvm-original-di-preservation %p/Inputs/sample.json --acceptance-test | FileCheck %s
22
CHECK: DILocation Bugs:
33
CHECK-NEXT: test.ll:
44
CHECK-NEXT: no-name:
@@ -20,7 +20,7 @@ CHECK-NEXT: fn_name: fn1
2020
CHECK-NEXT: instr: extractvalue
2121
CHECK: Errors detected for:
2222

23-
RUN: not %llvm-original-di-preservation %p/Inputs/sample.json --error-test --compress | FileCheck %s --check-prefix=COMPRESS
23+
RUN: not %llvm-original-di-preservation %p/Inputs/sample.json --acceptance-test --reduce | FileCheck %s --check-prefix=COMPRESS
2424
COMPRESS: DILocation Bugs:
2525
COMPRESS-NEXT: test.ll:
2626
COMPRESS-NEXT: no-name:
@@ -34,7 +34,7 @@ COMPRESS-NEXT: fn_name: fn
3434
COMPRESS-NEXT: instr: insertvalue
3535
COMPRESS: Errors detected for:
3636

37-
RUN: not %llvm-original-di-preservation %p/Inputs/origin.json --error-test --compress | FileCheck %s --check-prefix=ORIGIN
37+
RUN: not %llvm-original-di-preservation %p/Inputs/origin.json --acceptance-test --reduce | FileCheck %s --check-prefix=ORIGIN
3838
ORIGIN: DILocation Bugs:
3939
ORIGIN-NEXT: test.ll:
4040
ORIGIN-NEXT: LoopVectorizePass:
@@ -66,5 +66,5 @@ ORIGIN-NEXT: #18 0x00005895cfae1224 llvm::DevirtSCCRepeatedPass::run(llv
6666
ORIGIN-NEXT: #19 0x00005895d1e5067d llvm::detail::PassModel, llvm::LazyCallGraph&, llvm::CGSCCUpdateResult&>::run(llvm::LazyCallGraph::SCC&, llvm::AnalysisManager&, llvm::LazyCallGraph&, llvm::CGSCCUpdateResult&) /tmp/llvm-project/llvm/include/llvm/IR/PassManagerInternal.h:91:5
6767
ORIGIN: Errors detected for:
6868

69-
RUN: %llvm-original-di-preservation %p/Inputs/non-existent.json --error-test | FileCheck %s --check-prefix=EMPTY
69+
RUN: %llvm-original-di-preservation %p/Inputs/non-existent.json --acceptance-test | FileCheck %s --check-prefix=EMPTY
7070
EMPTY: No errors detected for:
Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
1-
RUN: %llvm-original-di-preservation %p/Inputs/sample.json --report-file %t.html | FileCheck %s
1+
RUN: %llvm-original-di-preservation %p/Inputs/sample.json --report-html-file %t.html | FileCheck %s
22
RUN: diff -w %p/Inputs/expected-sample.html %t.html
33
CHECK: The {{.+}}.html generated.
44
CHECK-NOT: Skipped lines:
55

6-
RUN: %llvm-original-di-preservation %p/Inputs/corrupted.json --report-file %t2.html | FileCheck %s -check-prefix=CORRUPTED
6+
RUN: %llvm-original-di-preservation %p/Inputs/corrupted.json --report-html-file %t2.html | FileCheck %s -check-prefix=CORRUPTED
77
RUN: diff -w %p/Inputs/expected-skipped.html %t2.html
88
CORRUPTED: Skipped lines: 3
99
CORRUPTED: Skipped bugs: 1
1010

11-
RUN: %llvm-original-di-preservation --compress %p/Inputs/sample.json --report-file %t3.html | FileCheck %s -check-prefix=COMPRESSED
11+
RUN: %llvm-original-di-preservation --reduce %p/Inputs/sample.json --report-html-file %t3.html | FileCheck %s -check-prefix=REDUCE
1212
RUN: diff -w %p/Inputs/expected-compressed.html %t3.html
13-
COMPRESSED: The {{.+}}.html generated.
14-
COMPRESSED-NOT: Skipped lines:
13+
REDUCE: The {{.+}}.html generated.
14+
REDUCE-NOT: Skipped lines:
1515

16-
RUN: %llvm-original-di-preservation %p/Inputs/origin.json --report-file %t4.html | FileCheck %s
16+
RUN: %llvm-original-di-preservation %p/Inputs/origin.json --report-html-file %t4.html | FileCheck %s
1717
RUN: diff -w %p/Inputs/expected-origin.html %t4.html

llvm/utils/llvm-original-di-preservation.py

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -497,11 +497,13 @@ def Main():
497497
parser = argparse.ArgumentParser()
498498
opts = parse_program_args(parser)
499499

500-
if opts.report_html_file is not None and not opts.report_html_file.endswith(".html"):
500+
if opts.report_html_file is not None and not opts.report_html_file.endswith(
501+
".html"
502+
):
501503
print("error: The output file must be '.html'.")
502504
sys.exit(1)
503505

504-
if opts.error_test:
506+
if opts.acceptance_test:
505507
if os.path.isdir(opts.file_name):
506508
print(f"error: Directory passed as input file: '{opts.file_name}'")
507509
sys.exit(1)
@@ -582,7 +584,7 @@ def Main():
582584
di_loc_bug = DILocBug(origin, action, bb_name, fn_name, instr)
583585
if not di_loc_bug.key() in di_loc_set:
584586
di_loc_set.add(di_loc_bug.key())
585-
if opts.compress:
587+
if opts.reduce:
586588
pass_instr = bugs_pass + instr
587589
if not pass_instr in di_loc_pass_instr_set:
588590
di_loc_pass_instr_set.add(pass_instr)
@@ -605,7 +607,7 @@ def Main():
605607
di_sp_bug = DISPBug(action, name)
606608
if not di_sp_bug.key() in di_sp_set:
607609
di_sp_set.add(di_sp_bug.key())
608-
if opts.compress:
610+
if opts.reduce:
609611
pass_fn = bugs_pass + name
610612
if not pass_fn in di_sp_pass_fn_set:
611613
di_sp_pass_fn_set.add(pass_fn)
@@ -629,7 +631,7 @@ def Main():
629631
di_var_bug = DIVarBug(action, name, fn_name)
630632
if not di_var_bug.key() in di_var_set:
631633
di_var_set.add(di_var_bug.key())
632-
if opts.compress:
634+
if opts.reduce:
633635
pass_var = bugs_pass + name
634636
if not pass_var in di_var_pass_var_set:
635637
di_var_pass_var_set.add(pass_var)
@@ -673,7 +675,7 @@ def Main():
673675
if di_variable_bugs:
674676
print_bugs_yaml("DIVariable Bugs", di_variable_bugs)
675677

676-
if opts.error_test:
678+
if opts.acceptance_test:
677679
if any((di_location_bugs, di_subprogram_bugs, di_variable_bugs)):
678680
# Add a newline gap after printing at least one error.
679681
print()

0 commit comments

Comments
 (0)