Skip to content

Commit 51a4da2

Browse files
Apply review in docs
1 parent 5306ed3 commit 51a4da2

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

clang/include/clang/CIR/Dialect/IR/CIRAttrs.td

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -458,7 +458,7 @@ def CIR_VisibilityAttr : CIR_EnumAttr<CIR_VisibilityKind, "visibility"> {
458458
//===----------------------------------------------------------------------===//
459459

460460
def BitfieldInfoAttr : CIR_Attr<"BitfieldInfo", "bitfield_info"> {
461-
let summary = "Represents a bit field info";
461+
let summary = "Represents info for a bit-field member";
462462
let description = [{
463463
Holds the following information about bitfields: name, storage type, size
464464
and position in the storage, and signedness.

clang/include/clang/CIR/Dialect/IR/CIROps.td

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1674,7 +1674,7 @@ def GetGlobalOp : CIR_Op<"get_global",
16741674
//===----------------------------------------------------------------------===//
16751675

16761676
def GetBitfieldOp : CIR_Op<"get_bitfield"> {
1677-
let summary = "Get a bitfield";
1677+
let summary = "Get the information for a bitfield member";
16781678
let description = [{
16791679
The `cir.get_bitfield` operation provides a load-like access to
16801680
a bit field of a record.
@@ -1688,8 +1688,8 @@ def GetBitfieldOp : CIR_Op<"get_bitfield"> {
16881688

16891689
Example:
16901690
Suppose we have a struct with multiple bitfields stored in
1691-
different storages. The `cir.get_bitfield` operation gets the value
1692-
of the bitfield
1691+
different members. The `cir.get_bitfield` operation gets the value
1692+
of the bitfield.
16931693
```C++
16941694
typedef struct {
16951695
int a : 4;

clang/lib/CIR/CodeGen/CIRGenExpr.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -335,9 +335,9 @@ RValue CIRGenFunction::emitLoadOfBitfieldLValue(LValue lv, SourceLocation loc) {
335335

336336
assert(!cir::MissingFeatures::armComputeVolatileBitfields());
337337

338-
mlir::Value field = builder.createGetBitfield(getLoc(loc), resLTy, ptr.getPointer(),
339-
ptr.getElementType(), info,
340-
lv.isVolatile(), false);
338+
mlir::Value field = builder.createGetBitfield(
339+
getLoc(loc), resLTy, ptr.getPointer(), ptr.getElementType(), info,
340+
lv.isVolatile(), false);
341341
assert(!cir::MissingFeatures::opLoadEmitScalarRangeCheck() && "NYI");
342342
return RValue::get(field);
343343
}

0 commit comments

Comments
 (0)