Skip to content

Commit 573a6a1

Browse files
committed
[lldb] [disassembler] chore: enhance VariableAnnotator to return structured data: update both annotate to Annotate class function name to follow lldb coding style
Signed-off-by: Nikita B <[email protected]>
1 parent 4d8706d commit 573a6a1

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

lldb/include/lldb/Core/Disassembler.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -598,7 +598,7 @@ class VariableAnnotator {
598598
public:
599599
/// Compute annotation strings for a single instruction and update `Live_`.
600600
/// Returns only the events that should be printed *at this instruction*.
601-
std::vector<std::string> annotate(Instruction &inst, Target &target,
601+
std::vector<std::string> Annotate(Instruction &inst, Target &target,
602602
lldb::ModuleSP module_sp);
603603

604604
/// Compute structured annotation data for a single instruction and update

lldb/source/Core/Disassembler.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -299,7 +299,7 @@ bool Disassembler::ElideMixedSourceAndDisassemblyLine(
299299
// The goal is to give users helpful live variable hints alongside the
300300
// disassembled instruction stream, similar to how debug information
301301
// enhances source-level debugging.
302-
std::vector<std::string> VariableAnnotator::annotate(Instruction &inst,
302+
std::vector<std::string> VariableAnnotator::Annotate(Instruction &inst,
303303
Target &target,
304304
lldb::ModuleSP module_sp) {
305305
auto structured_annotations = AnnotateStructured(inst, target, module_sp);
@@ -740,7 +740,7 @@ void Disassembler::PrintInstructions(Debugger &debugger, const ArchSpec &arch,
740740
address_text_size);
741741

742742
if ((options & eOptionVariableAnnotations) && target_sp) {
743-
auto annotations = annot.annotate(*inst, *target_sp, module_sp);
743+
auto annotations = annot.Annotate(*inst, *target_sp, module_sp);
744744
if (!annotations.empty()) {
745745
const size_t annotation_column = 100;
746746
inst_line.FillLastLineToColumn(annotation_column, ' ');

0 commit comments

Comments
 (0)