Skip to content

Commit 728686f

Browse files
committed
Comments. NFC
1 parent 9e4ab0e commit 728686f

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

mlir/lib/Conversion/AMDGPUToROCDL/AMDGPUToROCDL.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1721,7 +1721,6 @@ LogicalResult ScaledExtPacked816OpLowering::matchAndRewrite(
17211721
} else {
17221722
llvm_unreachable("invalid element type for scaled ext");
17231723
}
1724-
// Ok, so we need to construct ops depending on the sourceType and targetType.
17251724
// smallT = [Fp4, Fp8, Bf8]
17261725
// Bf8 = E5M2
17271726
// Fp8 = E4M3
@@ -1760,11 +1759,10 @@ LogicalResult ScaledExtPacked816OpLowering::matchAndRewrite(
17601759
op, op.getResult().getType(), castedSource, castedScale, scaleSel);
17611760
}
17621761
// smallT = [Fp6, Bf6]
1762+
// Fp6 = Float6E2M3FN
1763+
// Bf6 = Float6E3M2FN
17631764
// largeT = [F16, Bf16, F32]
17641765
//
1765-
// Fp6 = Float6E2M3FN
1766-
// Bf6 = Float6E3M2FN
1767-
17681766
// CvtPkScalePk16${largeT}${smallT}
17691767
else if (isa<Float6E2M3FNType>(srcElemType) and destElemType.isF16()) {
17701768
rewriter.replaceOpWithNewOp<ROCDL::CvtPkScalePk16F16Fp6Op>(

0 commit comments

Comments
 (0)