Skip to content

Commit 7558d41

Browse files
committed
1 parent 5789cca commit 7558d41

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ void SetSigProcMask(__sanitizer_sigset_t *set, __sanitizer_sigset_t *oldset) {
169169
// Equivalently: newset[signum] = newset[signum] & oldset[signum]
170170
static void KeepUnblocked(__sanitizer_sigset_t &newset,
171171
__sanitizer_sigset_t &oldset, int signum) {
172-
// FIXME: this causes mysterious failures on Android
172+
// FIXME: https://github.com/google/sanitizers/issues/1816
173173
if (SANITIZER_ANDROID || !internal_sigismember(&oldset, signum))
174174
internal_sigdelset(&newset, signum);
175175
}
@@ -179,7 +179,7 @@ static void KeepUnblocked(__sanitizer_sigset_t &newset,
179179
void BlockSignals(__sanitizer_sigset_t *oldset) {
180180
__sanitizer_sigset_t currentset;
181181
# if !SANITIZER_ANDROID
182-
// FIXME: SetSigProcMask cause mysterious failures on Android
182+
// FIXME: https://github.com/google/sanitizers/issues/1816
183183
SetSigProcMask(NULL, &currentset);
184184
# endif
185185

@@ -201,7 +201,7 @@ void BlockSignals(__sanitizer_sigset_t *oldset) {
201201
# if SANITIZER_LINUX && !SANITIZER_ANDROID
202202
// Don't block synchronous signals
203203
// but also don't unblock signals that the user had deliberately blocked.
204-
// FIXME: this causes mysterious failures on Android
204+
// FIXME: https://github.com/google/sanitizers/issues/1816
205205
KeepUnblocked(newset, currentset, SIGSEGV);
206206
KeepUnblocked(newset, currentset, SIGBUS);
207207
KeepUnblocked(newset, currentset, SIGILL);

0 commit comments

Comments
 (0)