Skip to content

Commit 921a1ba

Browse files
committed
implement feedback
1 parent cccb6ad commit 921a1ba

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

llvm/lib/IR/Verifier.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6367,7 +6367,7 @@ void Verifier::visitIntrinsicCall(Intrinsic::ID ID, CallBase &Call) {
63676367
"SGPR arguments must have the `inreg` attribute", &Call);
63686368
Check(!Call.paramHasAttr(3, Attribute::InReg),
63696369
"VGPR arguments must not have the `inreg` attribute", &Call);
6370-
Check(dyn_cast_or_null<UnreachableInst>(Call.getNextNode()),
6370+
Check(isa_and_present<UnreachableInst>(Call.getNextNode()),
63716371
"amdgcn_cs_chain must precede unreachable", &Call);
63726372
break;
63736373
}

llvm/test/Verifier/AMDGPU/intrinsic-amdgpu-cs-chain.ll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,4 +124,4 @@ define amdgpu_cs_chain void @set_inactive_chain_arg_inreg(ptr addrspace(1) %out,
124124
%tmp = call i32 @llvm.amdgcn.set.inactive.chain.arg(i32 %active, i32 inreg %inactive) #0
125125
store i32 %tmp, ptr addrspace(1) %out
126126
ret void
127-
}
127+
}

0 commit comments

Comments
 (0)