Add TODO comment for AAPCS ABI check as requested

Andres-Salamanca · Andres-Salamanca · commit 95c427d39748 · 2025-08-04T15:00:31.000-05:00
diff --git a/clang/lib/CIR/CodeGen/CIRGenExpr.cpp b/clang/lib/CIR/CodeGen/CIRGenExpr.cpp
@@ -322,6 +322,7 @@ void CIRGenFunction::emitStoreOfScalar(mlir::Value value, Address addr,
   assert(!cir::MissingFeatures::opTBAA());
 }
 
+// TODO: Replace this with a proper TargetInfo function call.
 /// Helper method to check if the underlying ABI is AAPCS
 static bool isAAPCS(const TargetInfo &targetInfo) {
   return targetInfo.getABI().starts_with("aapcs");

Original file line number	Diff line number	Diff line change
`@@ -322,6 +322,7 @@ void CIRGenFunction::emitStoreOfScalar(mlir::Value value, Address addr,`
`322`	`322`	`assert(!cir::MissingFeatures::opTBAA());`
`323`	`323`	`}`
`324`	`324`
	`325`	`+// TODO: Replace this with a proper TargetInfo function call.`
`325`	`326`	`/// Helper method to check if the underlying ABI is AAPCS`
`326`	`327`	`static bool isAAPCS(const TargetInfo &targetInfo) {`
`327`	`328`	`return targetInfo.getABI().starts_with("aapcs");`