Skip to content

Commit a8f5dc8

Browse files
committed
Adjusts tests
- Compact reg numbers in vop test - Remove "undef" - Readjust types in wave32 test
1 parent 9e406a9 commit a8f5dc8

File tree

3 files changed

+23
-21
lines changed

3 files changed

+23
-21
lines changed

llvm/test/CodeGen/AMDGPU/sdwa-peephole-cndmask-vop2.mir

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,12 +30,12 @@ body: |
3030
; GFX11-NEXT: [[V_CNDMASK_B32_e32_:%[0-9]+]]:vgpr_32 = V_CNDMASK_B32_e32 killed [[V_LSHRREV_B32_e64_]], killed [[V_LSHRREV_B32_e64_1]], implicit $exec, implicit $vcc_lo
3131
; GFX11-NEXT: $vgpr0 = COPY [[V_CNDMASK_B32_e32_]]
3232
; GFX11-NEXT: SI_RETURN implicit $vgpr0
33-
%1:vgpr_32 = COPY $vgpr1
34-
%2:vgpr_32 = COPY $vgpr0
33+
%0:vgpr_32 = COPY $vgpr1
34+
%1:vgpr_32 = COPY $vgpr0
35+
%2:vgpr_32 = V_LSHRREV_B32_e64 16, %0, implicit $exec
3536
%3:vgpr_32 = V_LSHRREV_B32_e64 16, %1, implicit $exec
36-
%4:vgpr_32 = V_LSHRREV_B32_e64 16, %2, implicit $exec
37-
%7:vgpr_32 = V_CNDMASK_B32_e32 killed %3, killed %4, implicit $exec, implicit $vcc
38-
$vgpr0 = COPY %7
37+
%4:vgpr_32 = V_CNDMASK_B32_e32 killed %2, killed %3, implicit $exec, implicit $vcc
38+
$vgpr0 = COPY %4
3939
SI_RETURN implicit $vgpr0
4040
4141
...

llvm/test/CodeGen/AMDGPU/sdwa-peephole-cndmask-vop3-wave32.mir

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ body: |
5252
%1:vgpr_32 = IMPLICIT_DEF
5353
%2:vgpr_32 = V_PK_MAX_F16 8, undef %1, 8, undef %1, 0, 0, 0, 0, 0, implicit $mode, implicit $exec
5454
%3:vgpr_32 = V_LSHRREV_B32_e64 16, %2, implicit $exec
55-
%4:vgpr_32 = V_CNDMASK_B32_e64 0, 0, 0, undef %3, killed undef %0, implicit $exec
55+
%4:vgpr_32 = V_CNDMASK_B32_e64 0, 0, 0, %3, killed undef %0, implicit $exec
5656
$vgpr0 = COPY %4
5757
SI_RETURN implicit $vgpr0
5858
...
@@ -150,21 +150,23 @@ body: |
150150
---
151151
name: missing-carry-def
152152
tracksRegLiveness: true
153+
registers:
154+
- { id: 0, class: sreg_32_xm0_xexec }
153155
body: |
154156
bb.0:
155157
liveins: $vgpr0
156158
157159
; CHECK-LABEL: name: missing-carry-def
158160
; CHECK: liveins: $vgpr0
159161
; CHECK-NEXT: {{ $}}
160-
; CHECK-NEXT: [[DEF:%[0-9]+]]:vgpr_32 = IMPLICIT_DEF
162+
; CHECK-NEXT: [[DEF:%[0-9]+]]:sreg_32_xm0_xexec = IMPLICIT_DEF
161163
; CHECK-NEXT: [[V_LSHRREV_B32_e64_:%[0-9]+]]:vgpr_32 = V_LSHRREV_B32_e64 16, undef [[DEF]], implicit $exec
162164
; CHECK-NEXT: [[V_CNDMASK_B32_e64_:%[0-9]+]]:vgpr_32 = V_CNDMASK_B32_e64 0, 0, 0, [[V_LSHRREV_B32_e64_]], undef %0:sreg_32_xm0_xexec, implicit $exec
163165
; CHECK-NEXT: $vgpr0 = COPY [[V_CNDMASK_B32_e64_]]
164166
; CHECK-NEXT: SI_RETURN implicit $vgpr0
165-
%1:vgpr_32 = IMPLICIT_DEF
167+
%1:sreg_32_xm0_xexec = IMPLICIT_DEF
166168
%2:vgpr_32 = V_LSHRREV_B32_e64 16, undef %1:sreg_32_xm0_xexec, implicit $exec
167-
%3:vgpr_32 = V_CNDMASK_B32_e64 0, 0, 0, %2, undef %0, implicit $exec
169+
%3:vgpr_32 = V_CNDMASK_B32_e64 0, 0, 0, %2, undef %0:sreg_32_xm0_xexec, implicit $exec
168170
$vgpr0 = COPY %3
169171
SI_RETURN implicit $vgpr0
170172
...

llvm/test/CodeGen/AMDGPU/sdwa-peephole-cndmask-vop3-wave64.mir

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py UTC_ARGS: --version 5
21
# RUN: llc %s -mtriple=amdgcn -mcpu=gfx900 -run-pass=si-peephole-sdwa -o - | FileCheck %s
2+
# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py UTC_ARGS: --version 5
33

44
---
55
name: change-compare-to-vopc # carry-in def is a comparison that can be changed to VOPC
@@ -42,17 +42,17 @@ body: |
4242
; CHECK-NEXT: [[DEF:%[0-9]+]]:sreg_64_xexec = IMPLICIT_DEF
4343
; CHECK-NEXT: [[DEF1:%[0-9]+]]:vgpr_32 = IMPLICIT_DEF
4444
; CHECK-NEXT: [[V_PK_MAX_F16_:%[0-9]+]]:vgpr_32 = V_PK_MAX_F16 8, undef [[DEF1]], 8, undef [[DEF1]], 0, 0, 0, 0, 0, implicit $mode, implicit $exec
45-
; CHECK-NEXT: [[V_LSHRREV_B32_e64_:%[0-9]+]]:vgpr_32 = V_LSHRREV_B32_e64 16, undef [[V_PK_MAX_F16_]], implicit $exec
45+
; CHECK-NEXT: [[V_LSHRREV_B32_e64_:%[0-9]+]]:vgpr_32 = V_LSHRREV_B32_e64 16, [[V_PK_MAX_F16_]], implicit $exec
4646
; CHECK-NEXT: $vcc = COPY killed undef [[DEF]]
4747
; CHECK-NEXT: [[V_MOV_B32_e32_:%[0-9]+]]:vgpr_32 = V_MOV_B32_e32 0, implicit $exec
48-
; CHECK-NEXT: [[V_CNDMASK_B32_sdwa:%[0-9]+]]:vgpr_32 = V_CNDMASK_B32_sdwa 0, [[V_MOV_B32_e32_]], 0, undef [[V_PK_MAX_F16_]], 0, 6, 0, 6, 5, implicit $vcc, implicit $exec
48+
; CHECK-NEXT: [[V_CNDMASK_B32_sdwa:%[0-9]+]]:vgpr_32 = V_CNDMASK_B32_sdwa 0, [[V_MOV_B32_e32_]], 0, [[V_PK_MAX_F16_]], 0, 6, 0, 6, 5, implicit $vcc, implicit $exec
4949
; CHECK-NEXT: $vgpr0 = COPY [[V_CNDMASK_B32_sdwa]]
5050
; CHECK-NEXT: SI_RETURN implicit $vgpr0
5151
%0:sreg_64_xexec = IMPLICIT_DEF
5252
%1:vgpr_32 = IMPLICIT_DEF
53-
%2:vgpr_32 = V_PK_MAX_F16 8, %1, 8, %1, 0, 0, 0, 0, 0, implicit $mode, implicit $exec
54-
%3:vgpr_32 = V_LSHRREV_B32_e64 16, undef %2, implicit $exec
55-
%4:vgpr_32 = V_CNDMASK_B32_e64 0, 0, 0, %3, killed %0, implicit $exec
53+
%2:vgpr_32 = V_PK_MAX_F16 8, undef %1, 8, undef %1, 0, 0, 0, 0, 0, implicit $mode, implicit $exec
54+
%3:vgpr_32 = V_LSHRREV_B32_e64 16, %2, implicit $exec
55+
%4:vgpr_32 = V_CNDMASK_B32_e64 0, 0, 0, %3, killed undef %0, implicit $exec
5656
$vgpr0 = COPY %4
5757
SI_RETURN implicit $vgpr0
5858
...
@@ -82,7 +82,7 @@ body: |
8282
%1:vgpr_32 = IMPLICIT_DEF
8383
%2:vgpr_32 = V_PK_MAX_F16 8, undef %1, 8, undef %1, 0, 0, 0, 0, 0, implicit $mode, implicit $exec
8484
%3:vgpr_32 = V_LSHRREV_B32_e64 16, %2, implicit $exec
85-
%4:vgpr_32 = V_CNDMASK_B32_e64 0, 0, 0, %3, killed %0, implicit $exec
85+
%4:vgpr_32 = V_CNDMASK_B32_e64 0, 0, 0, %3, killed undef %0, implicit $exec
8686
$vgpr0 = COPY %4
8787
$vgpr1 = COPY %0
8888
SI_RETURN implicit $vgpr0
@@ -110,9 +110,9 @@ body: |
110110
; CHECK-NEXT: SI_RETURN implicit $vgpr0
111111
%0:vgpr_32 = IMPLICIT_DEF
112112
%2:vgpr_32 = IMPLICIT_DEF
113-
%3:sreg_64_xexec = V_CMP_EQ_U32_e64 %0, 1, implicit $exec
114-
%5:vgpr_32 = V_LSHRREV_B32_e64 16, %2, implicit $exec
115-
V_CMP_EQ_U32_e32 1, %2, implicit-def $vcc, implicit $exec
113+
%3:sreg_64_xexec = V_CMP_EQ_U32_e64 undef %0, 1, implicit $exec
114+
%5:vgpr_32 = V_LSHRREV_B32_e64 16, undef %2, implicit $exec
115+
V_CMP_EQ_U32_e32 1, undef %2, implicit-def $vcc, implicit $exec
116116
%6:vgpr_32 = V_CNDMASK_B32_e64 0, 0, 0, %5, %3, implicit $exec
117117
%7:vgpr_32 = V_CNDMASK_B32_e32 killed %5, killed %5, implicit $vcc, implicit $exec
118118
$vgpr0 = COPY %6
@@ -165,8 +165,8 @@ body: |
165165
; CHECK-NEXT: $vgpr0 = COPY [[V_CNDMASK_B32_e64_]]
166166
; CHECK-NEXT: SI_RETURN implicit $vgpr0
167167
%1:vgpr_32 = IMPLICIT_DEF
168-
%2:vgpr_32 = V_LSHRREV_B32_e64 16, %1, implicit $exec
169-
%3:vgpr_32 = V_CNDMASK_B32_e64 0, 0, 0, %2, undef %0, implicit $exec
168+
%2:vgpr_32 = V_LSHRREV_B32_e64 16, undef %1, implicit $exec
169+
%3:vgpr_32 = V_CNDMASK_B32_e64 0, 0, 0, %2, undef %0:sreg_64_xexec, implicit $exec
170170
$vgpr0 = COPY %3
171171
SI_RETURN implicit $vgpr0
172172
...

0 commit comments

Comments
 (0)