Skip to content

Commit b843008

Browse files
committed
Address review comments 2
1 parent 83f642f commit b843008

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

llvm/lib/Target/AMDGPU/Utils/AMDGPUPALMetadata.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -260,10 +260,10 @@ void AMDGPUPALMetadata::setEntryPoint(unsigned CC, StringRef Name) {
260260
getHwStage(CC)[".entry_point_symbol"] =
261261
MsgPackDoc.getNode(Name, /*Copy=*/true);
262262

263-
// For pal version 3.6 and above, entry_point is no longer required
263+
// For PAL version 3.6 and above, entry_point is no longer required.
264264
if (getPALVersion() < VersionTuple(3, 6)) {
265-
// Set .entry_point which is defined
266-
// to be _amdgpu_<stage>_main and _amdgpu_cs_main for non-shader functions
265+
// Set .entry_point which is defined to be _amdgpu_<stage>_main and
266+
// _amdgpu_cs_main for non-shader functions.
267267
SmallString<16> EPName("_amdgpu_");
268268
raw_svector_ostream EPNameOS(EPName);
269269
EPNameOS << getStageName(CC) + 1 << "_main";

llvm/lib/Target/AMDGPU/Utils/AMDGPUPALMetadata.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,6 @@
2121
namespace llvm {
2222

2323
class Module;
24-
class StringRef;
25-
class VersionTuple;
2624

2725
class AMDGPUPALMetadata {
2826
public:

0 commit comments

Comments
 (0)