comment better test

Created using spr 1.3.5-bogner

Author: MaskRay

llvm/lib/Target/Mips/AsmParser/MipsAsmParser.cpp

@@ -1316,6 +1316,7 @@ class MipsOperand : public MCParsedAsmOperand {
     int64_t Res;
     if (getImm()->evaluateAsAbsolute(Res))
       return isInt<Bits>(Res);
+    // Allow conservatively if not a parse-time constant.
     return true;
   }
 
@@ -1325,6 +1326,7 @@ class MipsOperand : public MCParsedAsmOperand {
     int64_t Res;
     if (getImm()->evaluateAsAbsolute(Res))
       return isUInt<Bits>(Res);
+    // Allow conservatively if not a parse-time constant.
     return true;
   }
 

llvm/lib/Target/Mips/MCTargetDesc/MipsMCCodeEmitter.cpp

@@ -735,7 +735,7 @@ unsigned MipsMCCodeEmitter::getImmOpValue(const MCInst &MI, const MCOperand &MO,
   unsigned MIFrm = MipsII::getFormat(MCII.get(MI.getOpcode()).TSFlags);
   if (!isa<MCTargetExpr>(Expr) && MIFrm == MipsII::FrmI) {
     Fixups.push_back(MCFixup::create(
-        0, Expr, MCFixupKind(Mips::fixup_Mips_AnyImm16), MI.getLoc()));
+        0, Expr, MCFixupKind(Mips::fixup_Mips_AnyImm16), Expr->getLoc()));
     return 0;
   }
   return getExprOpValue(Expr, Fixups, STI);

llvm/test/MC/Mips/fixup-expr.s

@@ -16,13 +16,18 @@ addiu $4, $5, .L0-.L1
 addiu $4, $5, .L2-.L1
 addiu $4, $5, .L2-.L0+0
 
+# CHECK:      andi $4, $5, 0xffff
+# CHECK:      slti $4, $5, -0x1
+andi $4, $5, v65535 # uimm16
+slti $4, $5, v65535 # simm16
+
 .ifdef ERR
-# ERR: :[[#@LINE+1]]:1: error: fixup value out of range [-32768, 65535]
+# ERR: :[[#@LINE+1]]:15: error: fixup value out of range [-32768, 65535]
 addiu $4, $5, v_32769
-# ERR: :[[#@LINE+1]]:1: error: fixup value out of range [-32768, 65535]
+# ERR: :[[#@LINE+1]]:21: error: fixup value out of range [-32768, 65535]
 addiu $4, $5, v65535+1
 
-# ERR: [[#@LINE+1]]:1: error: fixup value out of range [-32768, 65535]
+# ERR: [[#@LINE+1]]:18: error: fixup value out of range [-32768, 65535]
 addiu $4, $5, .L2-.L0+1
 .endif
 

llvm/test/MC/Mips/fixup-out-of-range.s

@@ -2,11 +2,11 @@
 # RUN: not llvm-mc -filetype=obj -triple=mips -o /dev/null %s 2>&1 | FileCheck %s --implicit-check-not=error:
 # RUN: not llvm-mc -filetype=obj -triple=mips64 -o /dev/null %s 2>&1 | FileCheck %s --implicit-check-not=error:
 
-# CHECK: [[#@LINE+1]]:3: error: unsupported relocation type
+# CHECK: [[#@LINE+1]]:16: error: unsupported relocation type
   ori  $4, $4, start
   ori  $4, $4, (start - .)
 
-# CHECK: [[#@LINE+1]]:3: error: unsupported relocation type
+# CHECK: [[#@LINE+1]]:18: error: unsupported relocation type
   addiu  $4, $4, start
   addiu  $4, $4, (start - .)