Skip to content

Commit c939551

Browse files
committed
[libc++] Install dependencies right before they're needed
This solves a tricky issue where we can't install the libc++ dependencies until after we've checked out the monorepo.
1 parent 7d249cf commit c939551

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

.github/workflows/libcxx-run-benchmarks.yml

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -34,17 +34,12 @@ jobs:
3434
with:
3535
python-version: '3.10'
3636

37-
- name: Install dependencies
38-
run: |
39-
python3 -m venv .venv
40-
source .venv/bin/activate
41-
python -m pip install -r libcxx/utils/requirements.txt
42-
python -m pip install pygithub
43-
4437
- name: Extract information from the PR
4538
id: vars
4639
run: |
40+
python3 -m venv .venv
4741
source .venv/bin/activate
42+
python -m pip install pygithub
4843
cat <<EOF | python >> ${GITHUB_OUTPUT}
4944
import github
5045
repo = github.Github("${{ github.token }}").get_repo("${{ github.repository }}")
@@ -65,6 +60,7 @@ jobs:
6560
- name: Run baseline
6661
run: |
6762
source .venv/bin/activate
63+
python -m pip install -r repo/libcxx/utils/requirements.txt
6864
baseline_commit=$(git -C repo merge-base ${{ steps.vars.outputs.pr_base }} ${{ steps.vars.outputs.pr_head }})
6965
./repo/libcxx/utils/test-at-commit --git-repo repo --commit ${baseline_commit} -B build/baseline -- -sv -j1 --param optimization=speed ${{ steps.vars.outputs.benchmarks }}
7066

0 commit comments

Comments
 (0)