Skip to content

Commit d40e8ff

Browse files
committed
Address PR comments, change diag string to indicate an intrinsic is not supported
1 parent f19dcf6 commit d40e8ff

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

llvm/lib/Target/DirectX/DXILOpLowering.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -778,7 +778,8 @@ class OpLowerer {
778778
case Intrinsic::not_intrinsic:
779779
continue;
780780
default: {
781-
DiagnosticInfoUnsupported Diag(F, "Unknown intrinsic?");
781+
DiagnosticInfoUnsupported Diag(
782+
F, "Unsupported intrinsic for DXIL lowering");
782783
M.getContext().diagnose(Diag);
783784
HasErrors |= true;
784785
break;

llvm/test/CodeGen/DirectX/unknown_intrinsic.ll renamed to llvm/test/CodeGen/DirectX/unsupported_intrinsic.ll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
; RUN: not opt -S -dxil-op-lower -mtriple=dxil-pc-shadermodel6.3-library %s 2>&1 | FileCheck %s
22

3-
; CHECK: error: <unknown>:0:0: in function llvm.vector.reduce.and.v4i32 i32 (<4 x i32>): Unknown intrinsic?
3+
; CHECK: error: <unknown>:0:0: in function llvm.vector.reduce.and.v4i32 i32 (<4 x i32>): Unsupported intrinsic for DXIL lowering
44
define i32 @fn_and(<4 x i32> %0) local_unnamed_addr #0 {
55
%2 = tail call i32 @llvm.vector.reduce.and.v4i32(<4 x i32> %0)
66
ret i32 %2

0 commit comments

Comments
 (0)