Address comments

Author: V-FEXrt

clang/lib/CodeGen/CGBuiltin.cpp

@@ -19113,14 +19113,9 @@ case Builtin::BI__builtin_hlsl_elementwise_isinf: {
     llvm::Type *Ty = Op->getType();
     assert(Ty->isIntegerTy(1) && "wave_active_any_true operand must be a bool");
 
-    llvm::FunctionType *FT =
-        llvm::FunctionType::get(Ty, {Ty}, /*isVarArg=*/false);
-    llvm::StringRef Name = Intrinsic::getName(
-        CGM.getHLSLRuntime().getWaveActiveAnyTrueIntrinsic());
-    return EmitRuntimeCall(CGM.CreateRuntimeFunction(FT, Name, {},
-                                                     /*Local=*/false,
-                                                     /*AssumeConvergent=*/true),
-                           {Op}, "hlsl.wave.activeanytrue");
+    Intrinsic::ID ID = CGM.getHLSLRuntime().getWaveActiveAnyTrueIntrinsic();
+    return EmitRuntimeCall(
+        Intrinsic::getOrInsertDeclaration(&CGM.getModule(), ID), {Op});
   }
   case Builtin::BI__builtin_hlsl_wave_active_count_bits: {
     Value *OpExpr = EmitScalarExpr(E->getArg(0));

clang/test/CodeGenHLSL/builtins/WaveActiveAnyTrue.hlsl

@@ -13,5 +13,6 @@ bool test(bool p1) {
   // CHECK-SPIRV:  %[[RET:.*]] = call spir_func i1 @llvm.spv.wave.activeanytrue(i1 %{{[a-zA-Z0-9]+}}) [ "convergencectrl"(token %[[#entry_tok0]]) ]
   // CHECK-DXIL:  %[[RET:.*]] = call i1 @llvm.dx.wave.activeanytrue(i1 %{{[a-zA-Z0-9]+}})
   // CHECK:  ret i1 %[[RET]]
+  // CHECK: fex
   return WaveActiveAnyTrue(p1);
 }

clang/test/SemaHLSL/BuiltIns/WaveActiveAnyTrue-errors.hlsl

@@ -15,7 +15,7 @@ struct Foo
   int a;
 };
 
-bool test_type_check_2(Foo p0) {
+bool test_type_check(Foo p0) {
   return __builtin_hlsl_wave_active_any_true(p0);
   // expected-error@-1 {{no viable conversion from 'Foo' to 'bool'}}
 }